8000 [dynamo] Replace `unimplemented` with `unimplemented_v2` · Issue #147913 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[dynamo] Replace unimplemented with unimplemented_v2 #147913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
12 of 19 tasks
williamwen42 opened this issue Feb 26, 2025 · 0 comments
Open
12 of 19 tasks

[dynamo] Replace unimplemented with unimplemented_v2 #147913

williamwen42 opened this issue Feb 26, 2025 · 0 comments
Assignees
Labels
module: compile ux UX issues related to torch.compile module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@williamwen42
Copy link
Member
williamwen42 commented Feb 26, 2025

Tracking issue convert all unimplemented calls to unimplemented_v2.

List of files that need conversion (tag yourself/comment to claim):

No need to add unittests to test/dynamo/test_graph_break_messages.py unless you think a graph break is significant.

cc @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames

@williamwen42 williamwen42 added oncall: pt2 module: dynamo module: compile ux UX issues related to torch.compile triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 26, 2025
@williamwen42 williamwen42 self-assigned this Feb 26, 2025
FFFrog added a commit that referenced this issue Feb 28, 2025
torch/_dynamo/variables/constant.py

#147913

ghstack-source-id: f8ac6dc
Pull Request resolved: #148158
FFFrog added a commit that referenced this issue Mar 1, 2025
torch/_dynamo/variables/constant.py

#147913

ghstack-source-id: 2a2faea
Pull Request resolved: #148158
pytorchmergebot pushed a commit that referenced this issue Mar 3, 2025
majing921201 pushed a commit to majing921201/pytorch that referenced this issue Mar 4, 2025
pytorchmergebot pushed a commit to min-jean-cho/pytorch that referenced this issue Mar 5, 2025
@zou3519 zou3519 reopened this Mar 6, 2025
pytorchmergebot pushed a commit that referenced this issue Mar 13, 2025
…namo/variables/base.py` (#148177)

Part of #147913

Replace `unimplemented` with`unimplemented_v2` in `torch/_dynamo/variables/base.py`

Pull Request resolved: #148177
Approved by: https://github.com/williamwen42
StrongerXi added a commit that referenced this issue Apr 15, 2025
…s/functions.py`

This addresses part of #147913.

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue Apr 15, 2025
…s/torch_functions.py`

This addresses part of #147913.

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue Apr 15, 2025
…s/torch_functions.py`

This addresses part of #147913.

ghstack-source-id: f626e10
Pull Request resolved: #151278
pytorchmergebot pushed a commit that referenced this issue Apr 27, 2025
…ynamo/variables/nn_module.py` (#151895)

Part of #147913

Replace `unimplemented` with`unimplemented_v2` in `torch/_dynamo/variables/nn_module.py`

Pull Request resolved: #151895
Approved by: https://github.com/williamwen42

Co-authored-by: William Wen <william.wen42@gmail.com>
pytorchmergebot pushed a commit that referenced this issue Apr 27, 2025
…ynamo/variables/lists.py` (#151873)

Part of #147913

Replace `unimplemented` with`unimplemented_v2` in `torch/_dynamo/variables/lists.py`

Pull Request resolved: #151873
Approved by: https://github.com/williamwen42

Co-authored-by: William Wen <william.wen42@gmail.com>
pytorchmergebot pushed a commit that referenced this issue Apr 28, 2025
…ynamo/variables/iter.py` (#151789)

Part of #147913

Replace `unimplemented` with`unimplemented_v2` in `torch/_dynamo/variables/iter.py`

Pull Request resolved: #151789
Approved by: https://github.com/Skylion007, https://github.com/williamwen42
StrongerXi added a commit that referenced this issue Apr 30, 2025
…s/torch_functions.py`

This addresses part of #147913.

ghstack-source-id: ed9484e
Pull Request resolved: #151278
StrongerXi added a commit that referenced this issue Apr 30, 2025
…mplemented_v2` in `variables/functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue Apr 30, 2025
…n `variables/functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue Apr 30, 2025
…mplemented_v2` in `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue Apr 30, 2025
…n `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 1, 2025
…s/torch_functions.py`

This addresses part of #147913.

ghstack-source-id: 26b24fa
Pull Request resolved: #151278
StrongerXi added a commit that referenced this issue May 1, 2025
…mplemented_v2` in `variables/functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue < 8000 a href="#ref-commit-7cb64ec" class="Link--secondary"> May 1, 2025
…mplemented_v2` in `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 1, 2025
…n `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 1, 2025
…n `variables/functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 2, 2025
…mplemented_v2` in `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 2, 2025
…n `variables/torch_functions.py`"

This addresses part of #147913.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames

[ghstack-poisoned]
StrongerXi added a commit that referenced this issue May 2, 2025
…s/torch_functions.py`

This addresses part of #147913.

ghstack-source-id: 181dda5
Pull Request resolved: #151278
pytorchmergebot pushed a commit that referenced this issue May 5, 2025
pytorchmergebot pushed a commit that referenced this issue May 5, 2025
…s/torch_functions.py` (#151278)

This addresses part of #147913.

Pull Request resolved: #151278
Approved by: https://github.com/Skylion007, https://github.com/williamwen42
ghstack dependencies: #151277
pytorchmergebot pushed a commit that referenced this issue May 7, 2025
…ynamo/variables/misc.py` [1/2] (#152274)

Part of #147913

Replace `unimplemented` with`unimplemented_v2` in `torch/_dynamo/variables/misc.py`

Pull Request resolved: #152274
Approved by: https://github.com/williamwen42

Co-authored-by: William Wen <william.wen42@gmail.com>
pytorchbot pushed a commit that referenced this issue May 14, 2025
…s/functions.py` (#151277)

This addresses part of #147913.

Pull Request resolved: #151277
Approved by: https://github.com/S
67ED
kylion007, https://github.com/williamwen42

(cherry picked from commit 9e24f9b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: compile ux UX issues related to torch.compile module: dynamo oncall: pt2 triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
0