8000 [Dynamo] Replace `unimplemented` with `unimplemented_v2` in `torch/_dynamo/variables/lists.py` by shink · Pull Request #151873 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/lists.py #151873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/lists.py #151873

wants to merge 7 commits into from

Conversation

shink
Copy link
Contributor
@shink shink commented Apr 22, 2025 •
edited by pytorch-bot bot
Loading

Part of #147913

Replace unimplemented withunimplemented_v2 in torch/_dynamo/variables/lists.py

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Apr 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151873

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2196f62 with merge base e4a1a16 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shink
Copy link
Contributor Author
shink commented Apr 22, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Apr 22, 2025
@bdhirsh bdhirsh requested a review from williamwen42 April 22, 2025 23:38
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Apr 22, 2025
williamwen42
williamwen42 requested changes Apr 23, 2025
View reviewed changes
Copy link
Member
@williamwen42 williamwen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits

@williamwen42 williamwen42 mentioned this pull request Apr 23, 2025
Open
19 tasks
@shink
Copy link
Contributor Author
shink commented Apr 24, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here
8000

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/lists onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/lists && git pull --rebase)

@shink
Copy link
Contributor Author
shink commented Apr 24, 2025

@williamwen42 Many thanks for your review. Please have another look at this. Thanks for your time!

@shink
Copy link
Contributor Author
shink commented Apr 25, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 25, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shink
Copy link
Contributor Author
shink commented Apr 25, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shink
Copy link
Contributor Author
shink commented Apr 27, 2025

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

shink and others added 2 commits April 27, 2025 01:30
@shink @pytorchmergebot
replace
648c838
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
ebf02c9 
Co-authored-by: William Wen <william.wen42@gmail.com>
shink and others added 5 commits April 27, 2025 01:30
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
edb031a 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
09b2754 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
7905665 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
bc8fbe2 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/lists.py
2196f62 
Co-authored-by: William Wen <william.wen42@gmail.com>
@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/lists onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/lists && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Apr 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shink
Copy link
Contributor Author
shink commented Apr 27, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 27, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shink @pytorchmergebot @williamwen42 @bdhirsh @pytorchbot
0