Replace unimplemented with unimplemented_v2 for dynamo #148158
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148158
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4a2d3af with merge base 7ae0e0b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
williamwen42
requested changes
Feb 28, 2025
Skylion007
approved these changes
Mar 1, 2025
williamwen42
approved these changes
Mar 3, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
torch/_dynamo/variables/constant.py pytorch#147913 Pull Request resolved: pytorch#148158 Approved by: https://github.com/williamwen42, https://github.com/Skylion007
pytorchmergebot
pushed a commit
to min-jean-cho/pytorch
that referenced
this pull request
Mar 5, 2025
torch/_dynamo/variables/constant.py pytorch#147913 Pull Request resolved: pytorch#148158 Approved by: https://github.com/williamwen42, https://github.com/Skylion007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in
2DFA
order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch/_dynamo/variables/constant.py
#147913
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames