Replace unimplemented with unimplemented_v2' in codegen.py`
#148069
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148069
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit 0b18379 with merge base 3985ce0 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label "topic: not user facing" |
torch/_dynamo/codegen.py
Outdated
| @@ -197,7 +197,15 @@ def __call__(self, value, allow_cache=True): | |||
| try: | |||
| self.call_reconstruct(source) | |||
| except NotImplementedError: | |||
| unimplemented(f"reconstruct: {source}") | |||
| unimplemented_v2( | |||
| gb_type="Reconstruction failure", | |||
There was a problem hiding this comment.
Should highlight here that this reconstruction failure is related to sources (differentiate from the other reconstruction failure)
There was a problem hiding this comment.
Changed, thanks!
There was a problem hiding this comment.
cc @anijain2305 is this graph break actually needed? I'd imagine if a source doesn't have a reconstruction rule, should it be a dynamo bug?
Some sources
|
torch/_dynamo/codegen.py
Outdated
| explanation=f"Dynamo has no bytecode reconstruction implemented for {type(source)} variable {source}.", | ||
| hints=[ | ||
| "Report an issue to PyTorch if you need reconstrtuction support. Note that objects that don't have" | ||
| "reconstruction rules may be fundamentally unreconstructable.", |
There was a problem hiding this comment.
Let's add *graph_break_hints.DYNAMO_BUG here, since we should be fixing these graph breaks.
There was a problem hiding this comment.
Change to hints=[*graph_break_hints.DYNAMO_BUG], thanks!
c3c9c42 to
0b18379
Compare
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: pull / linux-focal-py3.13-clang10 / test (default, 2, 5, lf.linux.4xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #147913
unimplementedincodegen.pyunimplementedcc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @williamwen42