[dynamo] replace unimplemented with unimplemented_v2 in variables/torch_functions.py
#151278
Conversation
…s/torch_functions.py` This addresses part of #147913. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/151278
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 9d61b43 with merge base 3849fd1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| unimplemented_v2( | ||
| gb_type="TypeError from user code", | ||
| context=f"{fn=}, {args=}, {kwargs=}", | ||
| explanation="No available `__torch_function__` override found", |
There was a problem hiding this comment.
Maybe mention that specifically, "all torch_function overrides returned NotImplemented"?
| unimplemented( | ||
| f"Accessing {name} on a tensor subclass with a __torch_function__ override is not supported" | ||
| unimplemented_v2( | ||
| gb_type="Tensor subclass attribute access", |
There was a problem hiding this comment.
| gb_type="Tensor subclass attribute access", | |
| gb_type="Unsupported Tensor subclass attribute access", |
| f"Calling overridden method {name} on a tensor" | ||
| " subclass with a __torch_function__ override is not supported" | ||
| unimplemented_v2( | ||
| gb_type="Tensor subclass method call", |
There was a problem hiding this comment.
| gb_type="Tensor subclass method call", | |
| gb_type="Tensor subclass overriden method call", |
| unimplemented( | ||
| f"Currently only support accessing overridden attributes that are functions or properties, but got {type(attr)}" # noqa: B950 | ||
| unimplemented_v2( | ||
| gb_type="Tensor subclass attribute access", |
There was a problem hiding this comment.
| gb_type="Tensor subclass attribute access", | |
| gb_type="Tensor subclass non-function/proprety overriden attribute access", |
There was a problem hiding this comment.
Added "Unsupported" in front, since the supported set here might change frequently.
| unimplemented_v2( | ||
| gb_type="TypeError from user code", | ||
| context=f"{fn=}, {args=}, {kwargs=}", | ||
| explanation="No available `__torch_function__` override found", |
| unimplemented( | ||
| f"Currently only support accessing overridden attributes that are functions or properties, but got {type(attr)}" # noqa: B950 | ||
| unimplemented_v2( | ||
| gb_type="Tensor subclass attribute access", |
There was a problem hiding this comment.
Added "Unsupported" in front, since the supported set here might change frequently.
| f"Calling overridden method {name} on a tensor" | ||
| " subclass with a __torch_function__ override is not supported" | ||
| unimplemented_v2( | ||
| gb_type="Tensor subclass method call", |
…n `variables/torch_functions.py`" This addresses part of #147913. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
…n `variables/torch_functions.py`" This addresses part of #147913. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
| unimplemented_v2( | ||
| gb_type="TypeError from user code", | ||
| context=f"{fn=}, {args=}, {kwargs=}", | ||
| explanation="All __torch_function__ overrides for returned NotImplemented", |
There was a problem hiding this comment.
| explanation="All __torch_function__ overrides for returned NotImplemented", | |
| explanation=f"All __torch_function__ overrides for function {fn} returned NotImplemented", |
…n `variables/torch_functions.py`" This addresses part of #147913. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot merge -f "unrelated jobs stuck" |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
unimplementedwithunimplemented_v2invariables/torch_functions.py#151278unimplementedwithunimplemented_v2invariables/functions.py#151277This addresses part of #147913.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames