8000 [Dynamo] Replace `unimplemented` with `unimplemented_v2` in `torch/_dynamo/variables/misc.py` [2/2] by shink · Pull Request #153039 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/misc.py [2/2] #153039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[Dynamo] Replace unimplemented with unimplemented_v2 in torch/_dynamo/variables/misc.py [2/2] #153039

wants to merge 11 commits into from

Conversation

shink
Copy link
Contributor
@shink shink commented May 7, 2025 •
edited by pytorch-bot bot
Loading

Part of #147913
Follow up: #152274

Replace unimplemented withunimplemented_v2 in torch/_dynamo/variables/misc.py

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented May 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/153039

Note: Links to docs will display an error until the docs builds have been completed.

❌ 6 New Failures

As of commit 99e70ae with merge base a636a92 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@shink
Copy link
Contributor Author
shink commented May 7, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label May 7, 2025
@shink
Copy link
Contributor Author
shink commented May 7, 2025

@williamwen42 This is a follow-up to #152274, could you please review this? Thanks!

@janeyx99 janeyx99 requested a review from williamwen42 May 7, 2025 19:41
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label May 7, 2025
@shink
Copy link
Contributor Author
shink commented May 8, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/misc-2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/misc-2 && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the fix/dynamo/v2/misc-2 branch from 9e6f676 to 9573cd2 Compare May 8, 2025 01:39
williamwen42
williamwen42 reviewed May 8, 2025
View reviewed changes
torch/_dynamo/variables/misc.py Outdated
explanation="Dynamo encountered bytecode (`PUSH_NULL`) specific "
"to Python 3.11+ but is running in an older Python version.",
hints=[
"Run your code with Python 3.11 or newer if you need to "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a DYNAMO_BUG - user should not encounter this graph break.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review. Have updated in this commit: 041b6d3

@williamwen42 williamwen42 mentioned this pull request May 8, 2025
Open
19 tasks
@williamwen42
Copy link
Member

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@shink
Copy link
Contributor Author
shink commented May 9, 2025 •
edited
Loading 8000

@williamwen42 Thanks for your approval. The reason for the CI failure is that the exception information (self.msg) thrown by unimplemented_v2 is dynamic, which causes the number of graph_breaks counted to be inconsistent with unimplemented.

pytorch/torch/_dynamo/exc.py

Lines 169 to 171 in 10234cc

def add_to_stats(self, category: str = "unimplemented") -> None:
self.category = category
counters[category][self.msg] += 1

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label May 9, 2025
@shink
Copy link
Contributor Author
shink commented May 9, 2025

Made a fix in this commit, please have another look again. Thanks!

@williamwen42
Copy link
Member

We should be using the gb_type field of unimplemented_v2 in add_to_stats instead of the full graph break message if we want to keep similar behavior as before.

@shink
Copy link
Contributor Author
shink commented May 12, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/misc-2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/misc-2 && git pull --rebase)

@shink
Copy link
Contributor Author
shink commented May 12, 2025 •
edited
Loading

@williamwen42 Could you please take another look? I added a arg counter_category to Unsupported. Does this make sense? See this commit: 76434aa

@shink
Copy link
Contributor Author
shink commented May 19, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/misc-2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/misc-2 && git pull --rebase)

@shink
Copy link
Contributor Author
shink commented May 19, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 19, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Apply lint suggestions

Details for Dev Infra team Raised by workflow job

@shink shink mentioned this pull request May 19, 2025
Closed
@shink
Copy link
Contributor Author
shink commented May 21, 2025

@pytorchbot rebase -b main

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

shink and others added 10 commits May 21, 2025 06:25
A373
@shink @pytorchmergebot
unimplemented_v2
62e9d2b
@shink @pytorchmergebot
update
768697c
@shink @pytorchmergebot
fix
161e76f
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/misc.py
591454a 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @williamwen42 @pytorchmergebot
Update torch/_dynamo/variables/misc.py
deef589 
Co-authored-by: William Wen <william.wen42@gmail.com>
@shink @pytorchmergebot
update
ad76a03
@shink @pytorchmergebot
fix
9f9cd87
@shink @pytorchmergebot
Revert "fix"
cd06960 
This reverts commit 98e3db5141fa6270dd1afe97761b2c25526afe49.
@shink @pytorchmergebot
exc
0d3145e
@shink @pytorchmergebot
update
c15cf04
@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix/dynamo/v2/misc-2 onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout fix/dynamo/v2/misc-2 && git pull --rebase)

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label May 21, 2025
@shink shink closed this Jun 10, 2025
@williamwen42
Copy link
Member

Will you merge this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees
No one assigned
Labels
module: dynamo open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shink @pytorchmergebot @williamwen42 @pytorchbot @janeyx99
0