8000 [v.2.6.0] Release Tracker · Issue #142814 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[v.2.6.0] Release Tracker #142814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kit1980 opened this issue Dec 10, 2024 · 68 comments
Closed

[v.2.6.0] Release Tracker #142814

kit1980 opened this issue Dec 10, 2024 · 68 comments
Labels
module: ci Related to continuous integration release tracker Add this label to release tracker issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
2.6.0

Comments

@kit1980
Copy link
Contributor
kit1980 commented Dec 10, 2024 •
edited
Loading

We cut a release branch for the 2.6.0 release.

Our plan from this point from this point is roughly:

  • Phase 1 (until 1/13/25): work on finalizing the release branch
  • Phase 2 (after 1/13/25): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 1/13/25):

Only low-risk changes may be cherry-picked from main:

  1. Fixes to regressions against the most recent minor release (e.g. 2.5.x for this release; see module: regression issue list)
  2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
  3. Critical fixes to new features introduced in the most recent minor release (e.g. 2.5.x for this release)
  4. Test/CI fixes
  5. Documentation improvements
  6. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
  7. Release branch specific changes (e.g. change version identifiers)

Any other change requires special dispensation from the release managers (currently @atalman, @malfet, @kit1980). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 1/13/25):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are Release-blocking critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

Changes will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

  1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

  2. Create (but do not land) a PR against the release branch.

    # Find the hash of the commit you want to cherry pick
# (for example, abcdef12345)
git log

git fetch origin release/2.6
git checkout release/2.6
git cherry-pick -x abcdef12345

# Submit a PR based against 'release/2.6' either:
# via the GitHub UI
git push my-fork

# via the GitHub CLI
gh pr create --base release/2.6

    You can also use the @pytorchbot cherry-pick command to cherry-pick your PR. To do this, just add a comment in your merged PR. For example:

    @pytorchbot cherry-pick --onto release/2.6 -c docs

    (-c docs - is the category of your changes - adjust accordingly):

    For more information, see pytorchbot cherry-pick docs.

  3. Make a request below with the following format:

Link to landed trunk PR (if applicable):
* 

Link to release branch PR:
* 

Criteria Category:
*
  1. Someone from the release team will reply with approved / denied or ask for more information.
  2. If approved, someone from the release team will merge your PR once the tests pass. Do not land the release branch PR yourself.

NOTE: Our normal tools (ghstack / ghimport, etc.) do not work on the release branch.

Please note HUD Link with branch CI status and link to the HUD to be provided here.
HUD

Versions

2.6.0

cc @seemethere @malfet @pytorch/pytorch-dev-infra
@kit1980 kit1980 added the release tracker Add this label to release tracker issues label Dec 10, 2024
@kit1980 kit1980 added this to the 2.6.0 milestone Dec 10, 2024
@kit1980 kit1980 pinned this issue Dec 10, 2024
@jbschlosser jbschlosser added module: ci Related to continuous integration triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Dec 11, 2024
@kit1980 kit1980 closed this as completed Dec 11, 2024
@kit1980
Copy link
Contributor Author
kit1980 commented Dec 11, 2024

Closing this temporarily until new branch cut.

@kit1980 kit1980 reopened this Dec 12, 2024
@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 12, 2024 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@kit1980: merged

@pytorchbot pytorchbot mentioned this issue Dec 12, 2024
Closed
@kit1980
Copy link
Contributor Author
kit1980 commented Dec 12, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):
*

Link to release branch PR:

Criteria Category:
Critical - reverts

@kit1980 merged

@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 12, 2024 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@kit1980 merged

@pytorchbot pytorchbot mentioned this issue Dec 12, 2024
Closed
@atalman
Copy link
Contributor
atalman 8000 commented Dec 12, 2024 •
edited
Loading

Link to landed trunk PR (if applicable):

  • NA

Link to release branch PR:

Criteria Category:

  • release only

@kit1980 merged

@kit1980
Copy link
Contributor Author
kit1980 commented Dec 12, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@kit1980 merged

@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 12, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical - fixes libtorch builds

@kit1980 merged

@pytorchbot pytorchbot mentioned this issue Dec 12, 2024
Closed
@XuehaiPan
Copy link
Collaborator
XuehaiPan commented Dec 13, 2024 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • Documentation improvements

@kit1980: @XuehaiPan this changes the public API and BC-breaking, no?
@XuehaiPan: @kit1980 the accelerator API is a new API that does not exist in 2.5.x. It is safe to rename them.
@kit1980: ok, merged

@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 13, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@malfet merged

@pytorchbot pytorchbot mentioned this issue Dec 13, 2024
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 14, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@atalman merged

@pytorchbot pytorchbot mentioned this issue Dec 14, 2024
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 14, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@atalman merged

@pytorchbot pytorchbot mentioned this issue Dec 14, 2024
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 16, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@atalman merged

@pytorchbot pytorchbot mentioned this issue Dec 16, 2024
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Dec 17, 2024 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category: Critical

@atalman merged

@pytorchbot pytorchbot mentioned this issue Dec 17, 2024
Closed
@pytorchbot pytorchbot mentioned this issue Jan 14, 2025
Closed
@kit1980
Copy link
Contributor Author
kit1980 commented Jan 14, 2025 •
edited
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

@kit1980 merged

@kit1980 kit1980 mentioned this issue Jan 14, 2025
Closed
@wanchaol
Copy link
Collaborator
wanchaol commented Jan 14, 2025 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • documentation

@atalman merged

@wanchaol
Copy link
Collaborator
wanchaol commented Jan 14, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:

  • documentation

@kit1980 merged

@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 15, 2025 •
edited by malfet
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Fixnewfeature - Test failures on release

@malfet: merged

@pytorchbot pytorchbot mentioned this issue Jan 15, 2025
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 15, 2025 •
edited by malfet
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@malfet: merged

@pytorchbot pytorchbot mentioned this issue Jan 15, 2025
Closed
@malfet
Copy link
Contributor
malfet commented Jan 15, 2025 •
edited by kit1980
Loading

Link to landed trunk PRs:

Link to cherry-pick PR:

Criteria category: RelEng?

@kit1980 merged

@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 16, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@kit1980: I'm going to merge this because it's a security-related issue we agreed to cherry-pick beforehand.
@kit1980 merged
@kit1980 reverted in 9c34a20 as the main commit was reverted

@pytorchbot pytorchbot mentioned this issue Jan 16, 2025
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 17, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

@kit1980 merged

@pytorchbot pytorchbot mentioned this issue Jan 17, 2025
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 21, 2025 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs changes, does not need to rebuild the rc

@atalman merged

@pytorchbot pytorchbot mentioned this issue Jan 21, 2025
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 23, 2025 •
edited by atalman
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs

@atalman merged

@pytorchbot pytorchbot mentioned this issue Jan 23, 2025
Closed
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 24, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical Crash : #145580

Merged by @malfet

@pytorchbot pytorchbot mentioned this issue Jan 24, 2025
Closed
@atalman
Copy link
Contributor
atalman commented Jan 24, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

  • NA

Link to release branch PR:

Criteria Category:

  • Release Only changes, improve file size of CUDA 12.6 binaries

Merged by @malfet

@pytorch pytorch deleted a comment from kit1980 Jan 24, 2025
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 24, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Critical -

Merged by @malfet

@pytorchbot pytorchbot mentioned this issue Jan 24, 2025
Closed
@kit1980
Copy link
Contributor Author
kit1980 commented Jan 24, 2025

Please note: We are no longer accepting cherry-pick requests after this point.

@pytorch pytorch deleted a comment from atalman Jan 24, 2025
@pytorchbot
Copy link
Collaborator
pytorchbot commented Jan 28, 2025 •
edited by kit1980
Loading

Link to landed trunk PR (if applicable):

Link to release branch PR:

Criteria Category:
Docs -

@kit1980 merged

@pytorchbot pytorchbot mentioned this issue Jan 28, 2025
Closed
@kit1980 kit1980 unpinned this issue Jan 29, 2025
@atalman atalman closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: ci Related to continuous integration release tracker Add this label to release tracker issues triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch OSS Dev Infra
Archived in project
Milestone
2.6.0
Development

No branches or pull requests
0