8000 Exclude py 31.3t triton package from PyTorch 3.13t wheel by atalman · Pull Request #143218 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

Exclude py 31.3t triton package from PyTorch 3.13t wheel #143218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

atalman
Copy link
Contributor
@atalman atalman commented Dec 13, 2024

Follow up after #143162
Include triton only for 3.13 packages not 3.13t

Copy link
pytorch-bot bot commented Dec 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143218

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 111 Cancelled Jobs, 24 Unrelated Failures

As of commit 1f1d021 with merge base fe9365f (image):

NEW FAILURE - The following job has failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 13, 2024
@atalman atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Dec 13, 2024
@atalman
Copy link
Contributor Author
atalman commented Dec 14, 2024

@pytorchmergebot merge -f "xpu and lint runner are not related"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman
Copy link
Contributor Author
atalman commented Dec 14, 2024

@pytorchbot cherry-pick --onto release/2.6 -c critical

pytorchbot pushed a commit that referenced this pull request Dec 14, 2024
Follow up after #143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: #143218
Approved by: https://github.com/kit1980

(cherry picked from commit 3bfdf6f)
@pytorchbot
Copy link
Collaborator

Cherry picking #143218

The cherry pick PR is at #143244 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor
malfet commented Dec 14, 2024

@atalman is there an issue somewhere with Python support matrix for 2.6 that says that 3.13t is not supported?

bluenote10 pushed a commit to bluenote10/pytorch that referenced this pull request Dec 14, 2024
)

Follow up after pytorch#143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: pytorch#143218
Approved by: https://github.com/kit1980
@atalman
Copy link
Contributor Author
atalman commented Dec 16, 2024

@malfet This is umbrella issue for Python 3.13 work: #130249 I believe, support for torch.compile is implemented by: @williamwen42

atalman added a commit that referenced this pull request Dec 16, 2024
Exclude py 31.3t triton package from PyTorch 3.13t wheel (#143218)

Follow up after #143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: #143218
Approved by: https://github.com/kit1980

(cherry picked from commit 3bfdf6f)

Co-authored-by: atalman <atalman@fb.com>
aditew01 pushed a commit to aditew01/pytorch that referenced this pull request Dec 18, 2024
)

Follow up after pytorch#143162
Include triton only for 3.13 packages not 3.13t
Pull Request resolved: pytorch#143218
Approved by: https://github.com/kit1980
@atalman
Copy link
Contributor Author
atalman commented Dec 23, 2024

@pytorchmergebot revert -c nosignal -m "this constrain is ignored see #143654"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@atalman your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 23, 2024
…3218)"

This reverts commit 3bfdf6f.

Reverted #143218 on behalf of https://github.com/atalman due to this constrain is ignored see #143654 ([comment](#143218 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Dec 23, 2024
@atalman
Copy link
Contributor Author
atalman commented Dec 23, 2024

not required closing

@atalman atalman closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR Merged Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0