8000 [cherry-pick] [dtensor] improve doc of the DTensor class (#144099) by wanchaol · Pull Request #144740 · pytorch/pytorch · GitHub
[go: up one dir, main page]

Skip to content

[cherry-pick] [dtensor] improve doc of the DTensor class (#144099) #144740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

wanchaol
Copy link
Collaborator
@wanchaol wanchaol commented Jan 14, 2025

as titled: explicitly list all public members to make sure the public API stays consistent, also use groupwise as the member order to make doc look better

Pull Request resolved: #144099
Approved by: https://github.com/awgu

(cherry picked from commit 48a05ee)

Fixes #ISSUE_NUMBER

cc @H-Huang @awgu @kwen2501 @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

as titled: explicitly list all public members to make sure the public
API stays consistent, also use groupwise as the member order to make doc
look better

Pull Request resolved: #144099
Approved by: https://github.com/awgu

(cherry picked from commit 48a05ee)
Copy link
pytorch-bot bot commented Jan 14, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144740

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0857938 with merge base f7e621c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jan 14, 2025
Copy link
Contributor
@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit e19c13d into release/2.6 Jan 14, 2025
157 checks passed
@github-actions github-actions bot deleted the dtensor_class_doc branch February 14, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0