8000 [BE] Parametrize `test_min_max` by malfet · Pull Request #144249 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[BE] Parametrize test_min_max #144249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BE] Parametrize test_min_max #144249

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Jan 6, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

It's better to have one unit test per dtype rather a combined one

@malfet
Update
33eb6eb 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner January 6, 2025 16:00
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144249

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 10 Pending, 1 Unrelated Failure

As of commit 33eb6eb with merge base f6488d8 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) topic: not user facing topic category labels Jan 6, 2025
This was referenced Jan 6, 2025
Closed
Closed
@malfet malfet changed the title [BE][MPS] Parametrize test_min_max [BE] Parametrize test_min_max Jan 6, 2025
pytorchmergebot pushed a commit that referenced this pull request Jan 6, 2025
@malfet @pytorchmergebot
[BE] Fix + parametrize test_min_max_nan_propagation (#144250)
ebeb433 
- `dtype` was not passed as argument to `torch.rand` before
- Condition bfloat16 testing on MacOS14+
Pull Request resolved: #144250
Approved by: https://github.com/Skylion007
ghstack dependencies: #144249
pytorchmergebot pushed a commit that referenced this pull request Jan 6, 2025
@malfet @pytorchmergebot
[MPS] Fix bitwise shifts for uint8 (#144251)
e56768f 
Previosly all bitwise operations were aliased to the same type, but this is wrong for shift ops

Rather than building an overly complex logic, let's just instantiate using shared `scalarToMetalTypeString` helper function

Fixes #144190
Pull Request resolved: #144251
Approved by: https://github.com/Skylion007
ghstack dependencies: #144249, #144250
pytorchbot pushed a commit that referenced this pull request Jan 14, 2025
@malfet @pytorchbot
[MPS] Fix bitwise shifts for uint8 (#144251)
4f11ee5 
Previosly all bitwise operations were aliased to the same type, but this is wrong for shift ops

Rather than building an overly complex logic, let's just instantiate using shared `scalarToMetalTypeString` helper function

Fixes #144190
Pull Request resolved: #144251
Approved by: https://github.com/Skylion007
ghstack dependencies: #144249, #144250

(cherry picked from commit e56768f)
@pytorchbot pytorchbot mentioned this pull request Jan 14, 2025
Merged
kit1980 pushed a commit that referenced this pull request Jan 14, 2025
@pytorchbot @malfet
[MPS] Fix bitwise shifts for uint8 (#144732)
a61b5b1 
[MPS] Fix bitwise shifts for uint8 (#144251)

Previosly all bitwise operations were aliased to the same type, but this is wrong for shift ops

Rather than building an overly complex logic, let's just instantiate using shared `scalarToMetalTypeString` helper function

Fixes #144190
Pull Request resolved: #144251
Approved by: https://github.com/Skylion007
ghstack dependencies: #144249, #144250

(cherry picked from commit e56768f)

Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@malfet
Copy link
Contributor Author
malfet commented Jan 15, 2025

@pytorchbot cherry-pick --onto release/2.6 -c foobar

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 15, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot cherry-pick: error: argument -c/--classification: invalid choice: 'foobar' (choose from 'regression', 'critical', 'fixnewfeature', 'docs', 'release')

usage: @pytorchbot cherry-pick --onto ONTO [--fixes FIXES] -c
                               {regression,critical,fixnewfeature,docs,release}

Try @pytorchbot --help for more info.

@malfet
Copy link
Contributor Author
malfet commented Jan 15, 2025

@pytorchbto cherry-pick --onto release/2.6 -c fixnewfeature

@malfet
Copy link
Contributor Author
malfet commented Jan 15, 2025

@pytorchbot cherry-pick --onto release/2.6 -c fixnewfeature --fixes "test failures on release"

pytorchbot pushed a commit that referenced this pull request Jan 15, 2025
@malfet @pytorchbot
[BE] Parametrize test_min_max (#144249)
fd44495 
It's better to have one unit test per dtype rather a combined one
Pull Request resolved: #144249
Approved by: https://github.com/Skylion007

(cherry picked from commit 11a0663)
@pytorchbot pytorchbot mentioned this pull request Jan 15, 2025
Merged
@pytorchbot
Copy link
Collaborator

Cherry picking #144249

The cherry pick PR is at #144814 and it is linked with issue test failures on release. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jan 15, 2025
Closed
malfet added a commit that referenced this pull request Jan 15, 2025
@pytorchbot @malfet
[BE] Parametrize test_min_max (#144814)
232eb25 
[BE] Parametrize `test_min_max` (#144249)

It's better to have one unit test per dtype rather a combined one
Pull Request resolved: #144249
Approved by: https://github.com/Skylion007

(cherry picked from commit 11a0663)

Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@github-actions github-actions bot deleted the gh/malfet/111/head branch February 14, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@manuelcandales manuelcandales Awaiting requested review from manuelcandales

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
3F4E
Development

Successfully merging this pull request may close these issues.
4 participants
@malfet @pytorchbot @Skylion007 @pytorchmergebot
0