[CD] Use Anaconda cmake for Mac builds #143054
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/143054
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit c821a62 with merge base 1b3f8b7 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
1f2ed7d to
a5d20e3
Compare
a5d20e3 to
17b7f7e
Compare
17b7f7e to
1505bc2
Compare
Jack-Khuu
approved these changes
Dec 12, 2024
atalman
approved these changes
Dec 12, 2024
It is only applies to MacOS (but I can leave this comment on PR, as I've been confused by our build script names myself) |
As newer one fails to find OpenMP
1505bc2 to
d6efa1f
Compare
d6efa1f to
c821a62
Compare
|
@pytorchbot merge -f "MacOS libtorch builds are green again" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.6 -c critical |
pytorchbot
pushed a commit
that referenced
this pull request
Dec 12, 2024
To find Anaconda-env-installed OpenMP (As OpenMP from PyPI is looking for it in a different places) For posterity: our build script names are very confusing: - [`.ci/wheel/build_wheel.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/wheel/build_wheel.sh) is only used for MacOS wheel/libtorch builds - [`.ci/manywheel/build.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/manywheel/build.sh) are used for Linux wheel/libtorch builds - [`.ci/pytorch/windows/build_pytorch.bat`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/pytorch/windows/build_pytorch.bat) is used for Windows wheel builds Fixes #142873 Pull Request resolved: #143054 Approved by: https://github.com/Jack-Khuu, https://github.com/atalman (cherry picked from commit 4d8357e)
Cherry picking #143054The cherry pick PR is at #143133 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
kit1980
pushed a commit
that referenced
this pull request
Dec 12, 2024
[CD] Use Anaconda cmake for Mac builds (#143054) To find Anaconda-env-installed OpenMP (As OpenMP from PyPI is looking for it in a different places) For posterity: our build script names are very confusing: - [`.ci/wheel/build_wheel.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/wheel/build_wheel.sh) is only used for MacOS wheel/libtorch builds - [`.ci/manywheel/build.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/manywheel/build.sh) are used for Linux wheel/libtorch builds - [`.ci/pytorch/windows/build_pytorch.bat`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/pytorch/windows/build_pytorch.bat) is used for Windows wheel builds Fixes #142873 Pull Request resolved: #143054 Approved by: https://github.com/Jack-Khuu, https://github.com/atalman (cherry picked from commit 4d8357e) Co-authored-by: Nikita Shulga <nshulga@meta.com>
bluenote10
pushed a commit
to bluenote10/pytorch
that referenced
this pull request
Dec 14, 2024
To find Anaconda-env-installed OpenMP (As OpenMP from PyPI is looking for it in a different places) For posterity: our build script names are very confusing: - [`.ci/wheel/build_wheel.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/wheel/build_wheel.sh) is only used for MacOS wheel/libtorch builds - [`.ci/manywheel/build.sh`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/manywheel/build.sh) are used for Linux wheel/libtorch builds - [`.ci/pytorch/windows/build_pytorch.bat`](https://github.com/pytorch/pytorch/blob/6cb6e8d790fce6a24e16bf03afd7275bd294ad9c/.ci/pytorch/windows/build_pytorch.bat) is used for Windows wheel builds Fixes pytorch#142873 Pull Request resolved: pytorch#143054 Approved by: https://github.com/Jack-Khuu, https://github.com/atalman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find Anaconda-env-installed OpenMP
(As OpenMP from PyPI is looking for it in a different places)
For posterity: our build script names are very confusing:
.ci/wheel/build_wheel.shis only used for MacOS wheel/libtorch builds.ci/manywheel/build.share used for Linux wheel/libtorch builds.ci/pytorch/windows/build_pytorch.batis used for Windows wheel buildsFixes #142873