[cherry-pick][dtensor] expose the __create_chunk_list__ in the doc (#144100) #144741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as titled, this PR expose this dunder method as a public API in the doc, so that different checkpoint implementations can leverage this protocol, instead of exposing a separate API Pull Request resolved: #144100 Approved by: https://github.com/awgu ghstack dependencies: #144099 (cherry picked from commit eb7a303)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144741
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 95f329f with merge base f7e621c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This looks like a special named private functions, than why it should be documented? |
Oh @malfet this is actually the protocol that shared between checkpoint save/load implementations (i.e. DCP) and DTensor. Some user on Slack is asking for an API about it, so I thought it's beneficial to expose this API in the doc |
kit1980
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled, this PR expose this dunder method as a public API in the doc, so that different checkpoint implementations can leverage this protocol, instead of exposing a separate API
Pull Request resolved: #144100
Approved by: https://github.com/awgu
ghstack dependencies: #144099
(cherry picked from commit eb7a303)
Fixes #ISSUE_NUMBER
cc @H-Huang @awgu @kwen2501 @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o