8000 [Release/2.6] Enable python-3.13t aarch64 builds by malfet · Pull Request #144878 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[Release/2.6] Enable python-3.13t aarch64 builds #144878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2025
Merged

[Release/2.6] Enable python-3.13t aarch64 builds #144878

merged 3 commits into from
Jan 15, 2025

Conversation

malfet
Copy link
Contributor
@malfet malfet commented Jan 15, 2025 •
edited
Loading

Cherry-picks following 2 commits

And regenerated the workflow file by running RELEASE_VERSION_TAG=2.6 .github/regenerate.sh

malfet added 2 commits January 15, 2025 09:56
@malfet
[BE] [CD] Remove pygit2 dep for aarch64_wheel build (#144716)
6e64d49 
As it's incompatible with 3.13t and only used to fetch the branch name, which could be done by running
```
git rev-parse --abbrev-ref HEAD
```

Also, remove yet another reference to long gone `master` branch.

Test plan:
  Download `manywheel-py3_11-cpu-aarch64.zip` produced by this PR, install it inside docker container and check it's version
```
# pip install torch-2.7.0.dev20250113+cpu-cp311-cp311-manylinux_2_28_aarch64.whl
...
Installing collected packages: mpmath, typing-extensions, sympy, networkx, MarkupSafe, fsspec, filelock, jinja2, torch
Successfully installed MarkupSafe-3.0.2 filelock-3.16.1 fsspec-2024.12.0 jinja2-3.1.5 mpmath-1.3.0 networkx-3.4.2 sympy-1.13.1 torch-2.7.0.dev20250113+cpu typing-extensions-4.12.2
root@434f2540345e:/# python
Python 3.11.9 (main, Aug  1 2024, 23:33:10) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import torch
>>> torch.__version__
'2.7.0.dev20250113+cpu'
```
Pull Request resolved: #144716
Approved by: https://github.com/atalman
ghstack dependencies: #144696, #144697

(cherry picked from commit 58302c4)
@malfet
[CD] Enable python3.13t builds for aarch64 (#144698)
aebf0e7 
But make sure that right numpy version is picked (2.0.2 does not support 3.13)

Pull Request resolved: #144698
Approved by: https://github.com/atalman
ghstack dependencies: #144696, #144697, #144716

(cherry picked from commit 6053242)
@malfet malfet requested a review from a team as a code owner January 15, 2025 17:57
@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Jan 15, 2025
@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jan 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/144878

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 27 Pending, 1 Unrelated Failure

As of commit ba26f90 with merge base f7e621c (image):

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet mentioned this pull request Jan 15, 2025
Closed
albanD
albanD approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator
@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@atalman
Copy link
Contributor
atalman commented Jan 15, 2025 •
edited
Loading

before regenerating the workflows please set RELEASE_VERSION_TAG=2.6 this should generate the workflow correctly for release and fix lint failure:
https://github.com/pytorch/pytorch/actions/runs/12794191555/job/35668779427?pr=144878#step:14:252

@kit1980 kit1980 merged commit a2639bc into release/2.6 Jan 15, 2025
86 of 113 checks passed
@github-actions github-actions bot deleted the malfet/cp-144716-144698 branch February 15, 2025 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit1980 kit1980 kit1980 approved these changes

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
release notes: releng release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malfet @atalman @kit1980 @albanD
0