8000 traduction ospath by Pyodin · Pull Request #764 · python/python-docs-fr · GitHub
[go: up one dir, main page]
Skip to content

traduction ospath #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 9, 2019
Merged

traduction ospath #764

merged 8 commits into from
Oct 9, 2019

Conversation

Pyodin
Copy link
Contributor
@Pyodin Pyodin commented May 23, 2019

No description provided.

awecx
awecx suggested changes May 23, 2019
View reviewed changes
Copy link
Contributor
@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette première PR.

@deronnax
Copy link
Collaborator

ah oui Pyodin, alors parmi les franchouillardises (que j'aurais pu te dire) : nous traduisons toujours returns par renvoie

@Seluj78
Copy link
Collaborator
Seluj78 commented May 24, 2019

Tu va voir, des franchouillardises inventées par les québéquois et/ou nous y'en a plein et des sympaa 😊

Seluj78
Seluj78 requested changes May 24, 2019
View reviewed changes
Copy link
Collaborator
@Seluj78 Seluj78 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour ta première PR 😄 Voici quelques autres commentaires en plus de ceux de mes collègues

Pyodin and others added 4 commits September 21, 2019 18:03
@Pyodin @Seluj78
Apply suggestions from Seluj78
f11f5de 
Co-Authored-By: Jules Lasne (jlasne) <jlasne@student.42.fr>
@Pyodin @awecx
Apply suggestions from awecx
4ea6b88 
Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
wrapping
7f41d8c
ajout majuscule Unicode
fd0d899
awecx
awecx suggested changes Sep 21, 2019
View reviewed changes
Copy link
Contributor
@awecx awecx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques remarques encore.
Sinon, le reste me semble bien.

library/os.path.po
"fichiers peuvent ne pas être représentés sous forme de chaînes de caractères "
"sous UNIX, ainsi, les programmes qui doivent prendre en charge les noms de "
"fichiers arbitraires sur UNIX doivent utiliser des chaînes d'octets pour "
"représenter leurs chemins d’accès. Inversement, l’utilisation de chaîne "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ou plus simplement : "les chaînes ne peuvent pas représenter" ...
Comme tu préfères.

8000
@Pyodin @awecx
Apply suggestions from code review
e1b9086 
correction awecx

Co-Authored-By: Antoine <43954001+awecx@users.noreply.github.com>
@deronnax
Copy link
Collaborator
deronnax commented Sep 30, 2019 •
edited
Loading

mais du coup après avoir appliqué les suggestions, il faut refaire le powrap parce que du coup la CI gueule 😅

$ powrap --check --quiet **/*.po
Would rewrap:
- library/os.path.po
The command "powrap --check --quiet **/*.po" exited with 1.

c'est simple : tu git pull, tu powrap library/os.path.po et tu commit le résultat

@JulienPalard JulienPalard merged commit c436fa9 into python:3.7 Oct 9, 2019
@JulienPalard
Copy link
Member

👍 merci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deronnax deronnax deronnax left review comments

@awecx awecx awecx requested changes

@Seluj78 Seluj78 Seluj78 requested changes

Assignees

@Pyodin Pyodin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Pyodin @deronnax @Seluj78 @JulienPalard @awecx
0