8000 fixed ui behaviour when replacing a foxx app by hkernbach · Pull Request #9719 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

fixed ui behaviour when replacing a foxx app #9719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and pr 8000 ivacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 10, 2019
Merged

Conversation

hkernbach
Copy link
Member

Pull Request Guidelines

Scope & Purpose

(Can you describe what functional change your PR is trying to effect?)

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

image

It was possible to replace an existing app without the "Run setup?" flag. This was not triggering a foxx replace or upgrade. It just tried to install a foxx service (obviously overwrite an existing mount-point) and failed.

This PR just sets that checkbox by default to true (in case of replace) and forbids that value to be changed. Because it is a needed dependency.

@hkernbach hkernbach added this to the devel milestone Aug 15, 2019
@hkernbach hkernbach requested a review from pluma August 15, 2019 10:13
@pluma
Copy link
Contributor
pluma commented Aug 30, 2019

It's possible to replace/upgrade a Foxx service via the Foxx HTTP API without running the setup. Aardvark should support this, too.

Failing that I'd expect the option to simply not exist at all. I don't think it makes sense to display a checkbox that can't be unchecked.

pluma and others added 3 commits August 30, 2019 17:03
* Revert "fixed ui behaviour when replacing a foxx app"

This reverts commit 6092465.

* Cleanup on aisle 3

* Typo

* Fixed param order

* Cleanup flags

* Actually use the queryParams
Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchacki mchacki merged commit 616f01b into devel Oct 10, 2019
@mchacki mchacki deleted the bug-fix/replace-foxx-app-ui branch October 10, 2019 12:29
ObiWahn added a commit that referenced this pull request Oct 11, 2019
…ture/one-shard-clean-up-2

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  Remove invokeOnAllElements (#10212)
  AQL Subquery: MultiDependencyRowFetcher (#10101)
  Bug fix/fix remote executor races (#10206)
  fix several inefficiencies in Store (#10189)
  Deprecate rocksdb.max-write-buffer-number startup option (#9654)
  fix arangosh with vst
ObiWahn added a commit that referenced this pull request Oct 14, 2019
…ture/cpp17

* 'devel' of https://github.com/arangodb/arangodb: (46 commits)
  use automatic parsing so we can seamlessly switch HTTP / VST. (#10241)
  fix handling of VST urls in test (#10240)
  if we answer a head request, we mustn't create a body for errors (#10227)
  Move containers into their own folder and namespace. (#10244)
  when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243)
  Fix content-type for JS APIs (#10225)
  Feature/one shard clean up 2 (#10238)
  Fix dbserver locking and releasing for hotbackup. (#10177)
  Improve timings for hotbackup locking. (#10229)
  unintentionally broke something. fixed...
  throw parse error if we fail to parse the json document (#10226)
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0