-
Notifications
You must be signed in to change notification settings - Fork 855
fixed ui behaviour when replacing a foxx app #9719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to replace/upgrade a Foxx service via the Foxx HTTP API without running the setup. Aardvark should support this, too. Failing that I'd expect the option to simply not exist at all. I don't think it makes sense to display a checkbox that can't be unchecked. |
* Revert "fixed ui behaviour when replacing a foxx app" This reverts commit 6092465. * Cleanup on aisle 3 * Typo * Fixed param order * Cleanup flags * Actually use the queryParams
This was referenced Sep 2, 2019
pluma
suggested changes
Sep 6, 2019
…ngodb into bug-fix/replace-foxx-app-ui
mchacki
approved these changes
Oct 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ObiWahn
added a commit
that referenced
this pull request
Oct 11, 2019
…ture/one-shard-clean-up-2 * 'devel' of https://github.com/arangodb/arangodb: Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) Remove invokeOnAllElements (#10212) AQL Subquery: MultiDependencyRowFetcher (#10101) Bug fix/fix remote executor races (#10206) fix several inefficiencies in Store (#10189) Deprecate rocksdb.max-write-buffer-number startup option (#9654) fix arangosh with vst
ObiWahn
added a commit
that referenced
this pull request
Oct 14, 2019
…ture/cpp17 * 'devel' of https://github.com/arangodb/arangodb: (46 commits) use automatic parsing so we can seamlessly switch HTTP / VST. (#10241) fix handling of VST urls in test (#10240) if we answer a head request, we mustn't create a body for errors (#10227) Move containers into their own folder and namespace. (#10244) when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243) Fix content-type for JS APIs (#10225) Feature/one shard clean up 2 (#10238) Fix dbserver locking and releasing for hotbackup. (#10177) Improve timings for hotbackup locking. (#10229) unintentionally broke something. fixed... throw parse error if we fail to parse the json document (#10226) Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Guidelines
Scope & Purpose
(Can you describe what functional change your PR is trying to effect?)
Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
It was possible to replace an existing app without the "Run setup?" flag. This was not triggering a foxx replace or upgrade. It just tried to install a foxx service (obviously overwrite an existing mount-point) and failed.
This PR just sets that checkbox by default to true (in case of replace) and forbids that value to be changed. Because it is a needed dependency.