8000 Convert many uses of ClusterComm to Fuerte by dhly-etc · Pull Request #10154 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Convert many uses of ClusterComm to Fuerte #10154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Oct 10, 2019

Conversation

dhly-etc
Copy link
Contributor
@dhly-etc dhly-etc commented Oct 2, 2019

Scope & Purpose

  • Strictly new functionality (i.e. a new feature / new option, no need for porting)

Converts all remaining uses of ClusterComm outside the Cluster folder to use the fuerte-based network methods APIs instead, and some inside the Cluster folder as well.

Between this PR and #10137, the only remaining uses should be in arangod/Cluster/v8-cluster.cpp, which exposes the ClusterComm API to JS, where it is used by a few different modules. This could be a somewhat annoying conversion, so it will be done in a separate branch.

Enterprise component: https://github.com/arangodb/enterprise/pull/339

Testing & Verification

This change is already covered by existing tests.

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6602/

@dhly-etc dhly-etc self-assigned this Oct 2, 2019
@dhly-etc dhly-etc marked this pull request as ready for review October 4, 2019 21:26
@dhly-etc dhly-etc requested review from jsteemann and graetzer October 4, 2019 21:26
@dhly-etc
Copy link
Contributor Author
dhly-etc commented Oct 9, 2019

@jsteemann jsteemann merged commit 13e24b2 into devel Oct 10, 2019
@jsteemann jsteemann deleted the feature/convert-clustercomm-use-to-network-apis branch October 10, 2019 12:03
ObiWahn added a commit that referenced this pull request Oct 11, 2019
…ture/one-shard-clean-up-2

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  Remove invokeOnAllElements (#10212)
  AQL Subquery: MultiDependencyRowFetcher (#10101)
  Bug fix/fix remote executor races (#10206)
  fix several inefficiencies in Store (#10189)
  Deprecate rocksdb.max-write-buffer-number startup option (#9654)
  fix arangosh with vst
ObiWahn added a commit that referenced this pull request Oct 14, 2019
…ture/cpp17

* 'devel' of https://github.com/arangodb/arangodb: (46 commits)
  use automatic parsing so we can seamlessly switch HTTP / VST. (#10241)
  fix handling of VST urls in test (#10240)
  if we answer a head request, we mustn't create a body for errors (#10227)
  Move containers into their own folder and namespace. (#10244)
  when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243)
  Fix content-type for JS APIs (#10225)
  Feature/one shard clean up 2 (#10238)
  Fix dbserver locking and releasing for hotbackup. (#10177)
  Improve timings for hotbackup locking. (#10229)
  unintentionally broke something. fixed...
  throw parse error if we fail to parse the json document (#10226)
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0