Convert many uses of ClusterComm to Fuerte #10154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 25, 2019 09:44
added 9 commits
October 2, 2019 14:31
jsteemann
suggested changes
Oct 7, 2019
graetzer
reviewed
Oct 7, 2019
graetzer
reviewed
Oct 7, 2019
graetzer
reviewed
Oct 7, 2019
graetzer
reviewed
Oct 7, 2019
graetzer
reviewed
Oct 7, 2019
graetzer
reviewed
Oct 9, 2019
graetzer
reviewed
Oct 9, 2019
graetzer
reviewed
Oct 9, 2019
graetzer
reviewed
Oct 9, 2019
graetzer
reviewed
Oct 9, 2019
graetzer
approved these changes
Oct 9, 2019
jsteemann
approved these changes
Oct 10, 2019
ObiWahn
added a commit
that referenced
this pull request
Oct 11, 2019
…ture/one-shard-clean-up-2 * 'devel' of https://github.com/arangodb/arangodb: Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) Remove invokeOnAllElements (#10212) AQL Subquery: MultiDependencyRowFetcher (#10101) Bug fix/fix remote executor races (#10206) fix several inefficiencies in Store (#10189) Deprecate rocksdb.max-write-buffer-number startup option (#9654) fix arangosh with vst
ObiWahn
added a commit
that referenced
this pull request
Oct 14, 2019
…ture/cpp17 * 'devel' of https://github.com/arangodb/arangodb: (46 commits) use automatic parsing so we can seamlessly switch HTTP / VST. (#10241) fix handling of VST urls in test (#10240) if we answer a head request, we mustn't create a body for errors (#10227) Move containers into their own folder and namespace. (#10244) when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243) Fix content-type for JS APIs (#10225) Feature/one shard clean up 2 (#10238) Fix dbserver locking and releasing for hotbackup. (#10177) Improve timings for hotbackup locking. (#10229) unintentionally broke something. fixed... throw parse error if we fail to parse the json document (#10226) Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Converts all remaining uses of ClusterComm outside the Cluster folder to use the fuerte-based network methods APIs instead, and some inside the Cluster folder as well.
Between this PR and #10137, the only remaining uses should be in
arangod/Cluster/v8-cluster.cpp, which exposes the ClusterComm API to JS, where it is used by a few different modules. This could be a somewhat annoying conversion, so it will be done in a separate branch.Enterprise component: https://github.com/arangodb/enterprise/pull/339
Testing & Verification
This change is already covered by existing tests.
http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6602/