fix several inefficiencies in Store #10189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests blue apart from unrelated http_server test failure. |
jsteemann
commented
Oct 9, 2019
neunhoef
approved these changes
Oct 9, 2019
There was a problem hiding this comment.
LGTM. We should probably backport this to 3.5 and maybe even to 3.4, since this could make a considerable difference for customers. Also, the change is local and well secured by tests. The port should be easy since so far 3.4 and 3.5 should be pretty similar.
4 tasks
ObiWahn
added a commit
that referenced
this pull request
Oct 11, 2019
…ture/one-shard-clean-up-2 * 'devel' of https://github.com/arangodb/arangodb: Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) Remove invokeOnAllElements (#10212) AQL Subquery: MultiDependencyRowFetcher (#10101) Bug fix/fix remote executor races (#10206) fix several inefficiencies in Store (#10189) Deprecate rocksdb.max-write-buffer-number startup option (#9654) fix arangosh with vst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Fix several inefficiencies in Store::apply.
Additionally refactor anonymous function
splitin Store.cpp and make it testable.Testing & Verification
This change is already covered by existing tests, such as scripts/unittest agency.
This PR adds tests that were used to verify all changes:
https://172.16.10.101/view/PR/job/arangodb-matrix-pr/6637/