8000 fix several inefficiencies in Store by jsteemann · Pull Request #10189 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

fix several inefficiencies in Store #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Fix several inefficiencies in Store::apply.
Additionally refactor anonymous function split in Store.cpp and make it testable.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Testing & Verification

This change is already covered by existing tests, such as scripts/unittest agency.

This PR adds tests that were used to verify all changes:

  • Added new C++ Unit Tests (Either GoogleTest or Catch-Test)

https://172.16.10.101/view/PR/job/arangodb-matrix-pr/6637/

@jsteemann jsteemann added this to the devel milestone Oct 8, 2019
@jsteemann
Copy link
Contributor Author

Tests blue apart from unrelated http_server test failure.

Copy link
Member
@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should probably backport this to 3.5 and maybe even to 3.4, since this could make a considerable difference for customers. Also, the change is local and well secured by tests. The port should be easy since so far 3.4 and 3.5 should be pretty similar.

@jsteemann jsteemann merged commit 8afad8d into devel Oct 10, 2019
@jsteemann jsteemann deleted the bug-fix/fix-apply-inefficiency branch October 10, 2019 09:30
ObiWahn added a commit that referenced this pull request Oct 11, 2019
…ture/one-shard-clean-up-2

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  Remove invokeOnAllElements (#10212)
  AQL Subquery: MultiDependencyRowFetcher (#10101)
  Bug fix/fix remote executor races (#10206)
  fix several inefficiencies in Store (#10189)
  Deprecate rocksdb.max-write-buffer-number startup option (#9654)
  fix arangosh with vst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0