8000 AQL Subquery: MultiDependencyRowFetcher by goedderz · Pull Request #10101 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

AQL Subquery: MultiDependencyRowFetcher #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Oct 10, 2019

Conversation

goedderz
Copy link
Member

Make the MultiDependencyRowFetcher aware of ShadowRows.

@goedderz goedderz added 1 Feature 3 AQL Query language related labels Sep 27, 2019
@goedderz goedderz added this to the devel milestone Sep 27, 2019
@goedderz goedderz self-assigned this Sep 27, 2019
@goedderz
Copy link
Member Author
goedderz commented Oct 8, 2019
8000

@goedderz goedderz marked this pull request as ready for review October 8, 2019 13:19
@goedderz goedderz requested review from mchacki and markuspf October 8, 2019 13:19
@goedderz
Copy link
Member Author
goedderz commented Oct 9, 2019

Copy link
Member
@mchacki mchacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


// Note that == and != here check whether the rows are *identical*, that is,
// the same row in the same block.
// TODO Make this a named method
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep as cleanup task

std::pair<ExecutionState, ShadowAqlItemRow> MultiDependencySingleRowFetcher::fetchShadowRow(size_t const atMost) {
// If any dependency is in an invalid state, but not done, refetch it
for (size_t dependency = 0; dependency < _dependencyInfos.size(); ++dependency) {
// TODO We should never fetch from upstream here, as we can't know atMost - only the executor does.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep this as todo, we potentially need to remove atMost in this API anyways.
See kanban board

Comment on lines +86 to +99
auto const begin = _dependencyInfos.cbegin();
auto const end = _dependencyInfos.cend();
// The previous loop assures that all dependencies must either have a valid
// index, or be both done and have no valid index.
TRI_ASSERT(std::all_of(begin, end, [this](auto const& dep) {
return isDone(dep) || indexIsValid(dep);
}));

bool const anyDone = std::any_of(begin, end, [this](auto const& dep) {
return !indexIsValid(dep);
});
bool const anyShadow = std::any_of(begin, end, [this](auto const& dep) {
return indexIsValid(dep) && isAtShadowRow(dep);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good assertion!

AE3A @mchacki mchacki merged commit 4e86de0 into devel Oct 10, 2019
@mchacki mchacki deleted the feature/aql-subquery-multi-dep-row-fetcher branch October 10, 2019 11:08
ObiWahn added a commit that referenced this pull request Oct 11, 2019
…ture/one-shard-clean-up-2

* 'devel' of https://github.com/arangodb/arangodb:
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  Remove invokeOnAllElements (#10212)
  AQL Subquery: MultiDependencyRowFetcher (#10101)
  Bug fix/fix remote executor races (#10206)
  fix several inefficiencies in Store (#10189)
  Deprecate rocksdb.max-write-buffer-number startup option (#9654)
  fix arangosh with vst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Feature 3 AQL Query language related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0