AQL Subquery: MultiDependencyRowFetcher #10101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-subquery-multi-dep-row-fetcher
…-subquery-multi-dep-row-fetcher
…-subquery-multi-dep-row-fetcher
…-subquery-multi-dep-row-fetcher
…-subquery-multi-dep-row-fetcher
…where WAITING was ignored
mchacki
approved these changes
Oct 10, 2019
|
|
||
| // Note that == and != here check whether the rows are *identical*, that is, | ||
| // the same row in the same block. | ||
| // TODO Make this a named method |
| std::pair<ExecutionState, ShadowAqlItemRow> MultiDependencySingleRowFetcher::fetchShadowRow(size_t const atMost) { | ||
| // If any dependency is in an invalid state, but not done, refetch it | ||
| for (size_t dependency = 0; dependency < _dependencyInfos.size(); ++dependency) { | ||
| // TODO We should never fetch from upstream here, as we can't know atMost - only the executor does. |
There was a problem hiding this comment.
Keep this as todo, we potentially need to remove atMost in this API anyways.
See kanban board
Comment on lines
+86
to
+99
| auto const begin = _dependencyInfos.cbegin(); | ||
| auto const end = _dependencyInfos.cend(); | ||
| // The previous loop assures that all dependencies must either have a valid | ||
| // index, or be both done and have no valid index. | ||
| TRI_ASSERT(std::all_of(begin, end, [this](auto const& dep) { | ||
| return isDone(dep) || indexIsValid(dep); | ||
| })); | ||
|
|
||
| bool const anyDone = std::any_of(begin, end, [this](auto const& dep) { | ||
| return !indexIsValid(dep); | ||
| }); | ||
| bool const anyShadow = std::any_of(begin, end, [this](auto const& dep) { | ||
| return indexIsValid(dep) && isAtShadowRow(dep); | ||
| }); |
ObiWahn
added a commit
that referenced
this pull request
Oct 11, 2019
…ture/one-shard-clean-up-2 * 'devel' of https://github.com/arangodb/arangodb: Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) Remove invokeOnAllElements (#10212) AQL Subquery: MultiDependencyRowFetcher (#10101) Bug fix/fix remote executor races (#10206) fix several inefficiencies in Store (#10189) Deprecate rocksdb.max-write-buffer-number startup option (#9654) fix arangosh with vst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the MultiDependencyRowFetcher aware of ShadowRows.