8000 when changing between leader and follower re-attempt connecting to circumvent OS resource shortages by dothebart · Pull Request #10243 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

when changing between leader and follower re-attempt connecting to circumvent OS resource shortages #10243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub&r 8000 dquo;, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

when changing between leader and follower re-attempt connecting to circumvent OS resource shortages #10243

merged 1 commit into from
Oct 14, 2019

Conversation

dothebart
Copy link
Contributor

The resilient testsuites family frequently disconnects from leader / follower to work out test states.
This may lead to instability in tests if the system fails to connect in one of these reconnects.
Known popular reasons for failing connects are IP-Port shortages.
To circumvent testfailure this PR will re-attempt connecting to the SUT after an increasing grace period several times.

Example of such a failed testrun:

2019-10-11T14:45:18.866Z [ RUN        ] testChangeCollection1_Repl
2019-10-11T14:45:20.653Z [     PASSED ] testChangeCollection1_Repl (setUp: 7ms, test: 1515ms, tearDown: 265ms)
2019-10-11T14:45:20.654Z [ RUN        ] testChangeCollection2_Repl
2019-10-11T14:45:52Z [10128] ERROR [9d7ea] Could not connect to endpoint 'tcp://127.0.0.1:10033', username: 'replicator-user'
2019-10-11T14:45:52.180Z [   FAILED   ] testChangeCollection2_Repl (setUp: 5ms, test: 1516ms, tearDown: 30005ms)
ArangoError: could not connect
    at connectToMaster (c:\vm02-windows\oskar\work\ArangoDB\tests\js\server\replication\static\replication-static.js:58:10)
    at Object.tearDown (c:\vm02-windows\oskar\work\ArangoDB\tests\js\server\replication\static\replication-static.js:2226:7)
    at c:\vm02-windows\oskar\work\ArangoDB\js\common\modules\jsunity\jsunity.js:484:16
    at Object.run (c:\vm02-windows\oskar\work\ArangoDB\js\common\modules\jsunity\jsunity.js:556:19)
    at Object.Run [as run] (c:\vm02-windows\oskar\work\ArangoDB\js\common\modules\jsunity.js:275:24)
    at c:\vm02-windows\oskar\work\ArangoDB\tests\js\server\replication\static\replication-static.js:2325:9
    at c:\vm02-windows\oskar\work\ArangoDB\tests\js\server\replication\static\replication-static.js:2329:3
    at RunTest (c:\vm02-windows\oskar\work\ArangoDB\js\common\modules\jsunity.js:389:12)
    at c:\vm02-windows\oskar\work\ArangoDB\js\common\modules\@arangodb\testrunner.js:66:13
    at arrayEach (c:\vm02-windows\oskar\work\ArangoDB\js\node\node_modules\lodash\lodash.js:516:11) - tearDown failed
2019-10-11T14:45:52.180Z [ RUN        ] testChangeCollectionIndexBuckets_Repl
2019-10-11T14:45:52.399Z [     PASSED ] testChangeCollectionIndexBuckets_Repl (setUp: 211ms, test: 0ms, tearDown: 8ms)

@dothebart dothebart requested review from jsteemann and KVS85 October 11, 2019 16:42
@dothebart
Copy link
Contributor Author

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6717/

@dothebart
Copy link
Contributor Author

tests green.

@KVS85 KVS85 merged commit 9883518 into devel Oct 14, 2019
@KVS85 KVS85 deleted the feature/replication-test-resillience branch October 14, 2019 08:54
ObiWahn added a commit that referenced this pull request Oct 14, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
a15f460 
…ture/cpp17

* 'devel' of https://github.com/arangodb/arangodb: (46 commits)
  use automatic parsing so we can seamlessly switch HTTP / VST. (#10241)
  fix handling of VST urls in test (#10240)
  if we answer a head request, we mustn't create a body for errors (#10227)
  Move containers into their own folder and namespace. (#10244)
  when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243)
  Fix content-type for JS APIs (#10225)
  Feature/one shard clean up 2 (#10238)
  Fix dbserver locking and releasing for hotbackup. (#10177)
  Improve timings for hotbackup locking. (#10229)
  unintentionally broke something. fixed...
  throw parse error if we fail to parse the json document (#10226)
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
  Bug fix/fix simple example dep proxy skip some regression test (#10213)
  fixed ui behaviour when replacing a foxx app (#9719)
  [devel] Fix document search (Ctrl+F/Cmd+F) (#10216)
  Convert many uses of ClusterComm to Fuerte (#10154)
  ...
ObiWahn added a commit that referenced this pull request Oct 14, 2019
@ObiWahn
Merge remote-tracking branch 'origin/feature/cpp17' into feature/cpp1…
7f8dcd9 
…7-remove-mac-hack

* origin/feature/cpp17:
  use automatic parsing so we can seamlessly switch HTTP / VST. (#10241)
  fix handling of VST urls in test (#10240)
  if we answer a head request, we mustn't create a body for errors (#10227)
  Move containers into their own folder and namespace. (#10244)
  when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243)
  Fix content-type for JS APIs (#10225)
  Feature/one shard clean up 2 (#10238)
  Fix dbserver locking and releasing for hotbackup. (#10177)
  Improve timings for hotbackup locking. (#10229)
  unintentionally broke something. fixed...
  throw parse error if we fail to parse the json document (#10226)
  Bug fix/improve stringutils performance (#10208)
  add option to talk to the SUT using VST (#10217)
  Doc - Added "log-output" example (#10207)
  fix it! (#10198)
  add missing include
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KVS85 KVS85 KVS85 approved these changes

@jsteemann jsteemann Awaiting requested review from jsteemann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3554
2 participants
@dothebart @KVS85
0