Fix content-type for JS APIs #10225
Merged
Fix content-type for JS APIs #10225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteemann
reviewed
Oct 10, 2019
lib/Rest/VstResponse.cpp
Outdated
| builder.add(currentHeader, VPackValue(item.second)); | ||
| } | ||
| if (_contentType != ContentType::VPACK) { // fuerte uses VPack as default |
There was a problem hiding this comment.
for content type "CUSTOM" this will write Content-Type: , because rest::contentTypeToString(CUSTOM) will return an empty string. Intentional?
There was a problem hiding this comment.
perhaps we need a more comprehensive fix
There was a problem hiding this comment.
I think we need to store a custom content type separately, or remove the special handling of the content-type altogether and handle it like all other headers.
jsteemann
approved these changes
Oct 10, 2019
dothebart
approved these changes
Oct 11, 2019
ObiWahn
added a commit
that referenced
this pull request
Oct 14, 2019
…ture/cpp17 * 'devel' of https://github.com/arangodb/arangodb: (46 commits) use automatic parsing so we can seamlessly switch HTTP / VST. (#10241) fix handling of VST urls in test (#10240) if we answer a head request, we mustn't create a body for errors (#10227) Move containers into their own folder and namespace. (#10244) when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243) Fix content-type for JS APIs (#10225) Feature/one shard clean up 2 (#10238) Fix dbserver locking and releasing for hotbackup. (#10177) Improve timings for hotbackup locking. (#10229) unintentionally broke something. fixed... throw parse error if we fail to parse the json document (#10226) Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include Bug fix/fix simple example dep proxy skip some regression test (#10213) fixed ui behaviour when replacing a foxx app (#9719) [devel] Fix document search (Ctrl+F/Cmd+F) (#10216) Convert many uses of ClusterComm to Fuerte (#10154) ...
ObiWahn
added a commit
that referenced
this pull request
Oct 14, 2019
…7-remove-mac-hack * origin/feature/cpp17: use automatic parsing so we can seamlessly switch HTTP / VST. (#10241) fix handling of VST urls in test (#10240) if we answer a head request, we mustn't create a body for errors (#10227) Move containers into their own folder and namespace. (#10244) when changing between leader and follower re-attempt connecting to circumvent OS resource shortages (#10243) Fix content-type for JS APIs (#10225) Feature/one shard clean up 2 (#10238) Fix dbserver locking and releasing for hotbackup. (#10177) Improve timings for hotbackup locking. (#10229) unintentionally broke something. fixed... throw parse error if we fail to parse the json document (#10226) Bug fix/improve stringutils performance (#10208) add option to talk to the SUT using VST (#10217) Doc - Added "log-output" example (#10207) fix it! (#10198) add missing include
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Fix response content-type
Testing & Verification
This change is already covered by existing tests, such as the http_server suite
http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/6692/