8000 Runtime error in permissions_endpoint by martinbpeters · Pull Request #513 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Runtime error in permissions_endpoint #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2019

Conversation

martinbpeters
Copy link
Contributor

Runtime error: grantee.permissions_grantee_type replaced with grantee.tag_name in the permissions_endpoint delete method.

Chris Shin and others added 3 commits October 4, 2019 14:20
Release v0.9
## 0.9 (4 Oct 2019)

* Added Metadata API endpoints (tableau#431)
* Added site settings for Data Catalog and Prep Conductor (tableau#434)
* Added new fields to ViewItem (tableau#331)
* Added support and samples for Tableau Server Personal Access Tokens (tableau#465)
* Added Permissions endpoints (tableau#429)
* Added tags to ViewItem (tableau#470)
* Added Databases and Tables endpoints (tableau#445)
* Added Flow endpoints (tableau#494)
* Added ability to filter projects by topLevelProject attribute (tableau#497)
* Improved server_info endpoint error handling (tableau#439)
* Improved Pager to take in keyword arguments (tableau#451)
* Fixed UUID serialization error while publishing workbook (tableau#449)
* Fixed materalized views in request body for update_workbook (tableau#461)
Runtime error: grantee.permissions_grantee_type replaced with grantee.tag_name in the permissions_endpoint delete method.
Runtime error in default_permissions_endpoint.py method delete_default_permission
@t8y8 t8y8 self-assigned this Oct 23, 2019
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes themselves look good.

Can you please do the following:

  1. Move this to be against the development branch
  2. Fix the linting failure, it looks like line indentation mismatches
  3. Make sure you've signed the CLA.

@martinbpeters martinbpeters changed the base branch from master to development October 25, 2019 07:54
@martinbpeters
Copy link
Contributor Author

Apologies for the delay. I've actioned those three items.

Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t8y8 t8y8 merged commit 808e5b9 into tableau:development Nov 4, 2019
@t8y8
Copy link
Collaborator
t8y8 commented Nov 4, 2019

Merged! Thanks for the fix!

@donedeal-martin
Copy link

Great! You're welcome. When do we expect this to make it into the master branch and released?

shinchris pushed a commit that referenced this pull request Feb 21, 2020
* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
shinchris pushed a commit that referenced this pull request Feb 21, 2020
Merging v0.10 changes from development to master

* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0