10000 Close missing brackets in log texts by shrmnk · Pull Request #508 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Close missing brackets in log texts #508

New issue
Merged
merged 2 commits into from
Nov 5, 2019
Merged

Conversation

shrmnk
Copy link
Contributor
@shrmnk shrmnk commented Oct 6, 2019

Minor fixes in logging texts for the workbooks_endpoint.py file

Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a simple fix and then looks good to me

@t8y8
Copy link
Collaborator
t8y8 commented Oct 14, 2019

@shrmnk Hey! Are you still interested in updating the patch and merging this?

@shrmnk
Copy link
Contributor Author
shrmnk commented Oct 15, 2019

Hey sorry missed out on this. Fixed!

@t8y8 t8y8 self-requested a review October 18, 2019 20:15
t8y8
t8y8 previously approved these changes Oct 18, 2019
Copy link
Collaborator
@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@t8y8
Copy link
Collaborator
t8y8 commented Oct 18, 2019

@shrmnk Looks good! But, as I was about to merge, I noticed this is against master, can you rebase it against development? I'll hit merge as soon as I see that come through.

@shrmnk
Copy link
Contributor Author
shrmnk commented Oct 21, 2019

Rebased to development, thanks!

@t8y8
Copy link
Collaborator
t8y8 commented Oct 23, 2019

It looks like it's still showing as a PR trying to merge in to 'master'

@t8y8 t8y8 self-assigned this Oct 23, 2019
@jacalata jacalata changed the base branch from master to development November 5, 2019 19:06
@jacalata
Copy link
Contributor
jacalata commented Nov 5, 2019

@t8y8 check I didn't break anything?

@t8y8
Copy link
Collaborator
t8y8 commented Nov 5, 2019

WE CAN CHANGE THE TARGET BRANCH?!?! I never knew!

@t8y8 t8y8 merged commit 5eccf20 into tableau:development Nov 5, 2019
@shrmnk shrmnk deleted the patch-1 branch November 6, 2019 02:28
shinchris pushed a commit that referenced this pull request Feb 21, 2020
* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
shinchris pushed a commit that referenced this pull request Feb 21, 2020
Merging v0.10 changes from development to master

* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0