8000 Close missing brackets in log texts by shrmnk · Pull Request #508 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Close missing brackets in log texts #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Close missing brackets in log texts #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb04bd
Close missing brackets in log texts
shrmnk Oct 6, 2019
75a1f90
Fix linting issue with missing space
shrmnk Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tableauserverclient/server/endpoint/workbooks_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def update(self, workbook_item):
url = "{0}/{1}".format(self.baseurl, workbook_item.id)
update_req = RequestFactory.Workbook.update_req(workbook_item)
server_response = self.put_request(url, update_req)
logger.info('Updated workbook item (ID: {0}'.format(workbook_item.id))
logger.info('Updated workbook item (ID: {0})'.format(workbook_item.id))
updated_workbook = copy.copy(workbook_item)
return updated_workbook._parse_common_tags(server_response.content, self.parent_srv.namespace)

Expand All @@ -104,8 +104,8 @@ def update_connection(self, workbook_item, connection_item):
server_response = self.put_request(url, update_req)
connection = ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)[0]

logger.info('Updated workbook item (ID: {0} & connection item {1}'.format(workbook_item.id,
connection_item.id))
logger.info('Updated workbook item (ID: {0} & connection item {1})'.format(workbook_item.id,
connection_item.id))
return connection

# Download workbook contents with option of passing in filepath
Expand Down Expand Up @@ -151,7 +151,7 @@ def view_fetcher():
return self._get_views_for_workbook(workbook_item, usage)

workbook_item._set_views(view_fetcher)
logger.info('Populated views for workbook (ID: {0}'.format(workbook_item.id))
logger.info('Populated views for workbook (ID: {0})'.format(workbook_item.id))

def _get_views_for_workbook(self, workbook_item, usage):
url = "{0}/{1}/views".format(self.baseurl, workbook_item.id)
Expand Down
0