8000 Added a functionality to move an existing project (change it's parent_id) by update method by wolkiewiczk · Pull Request #560 · tableau/server-client-python · GitHub
[go: up one dir, main page]

Skip to content

Added a functionality to move an existing project (change it's parent_id) by update method #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Added a functionality to move an existing project (change it's parent_id) by update method #560

merged 1 commit into from
Feb 12, 2020

Conversation

wolkiewiczk
Copy link
Contributor

I have added a minor change to request_factory file to enable updating the parent_id of a project. As described in an issue I really need that functionality. Please let me know if I did not miss something important, I tested it manually and it worked properly. Mocked unit test already existed.
Link to an issue:
#559

@james-baker
Copy link

CLA received for wolkiewiczk.

@wolkiewiczk
Copy link
Contributor Author

@james-baker is there any chance that someone will check pull requests anytime soon? I see that many of them are even since november and I am afraid that the project is abandoned or at least frozen for a while. I am asking because I really need this functionality and I am thinking if it is worth waiting with implementation or I should just make some workaround for the time it is not a part of the library and change it later.

@shinchris shinchris merged commit 0b3dc62 into tableau:development Feb 12, 2020
@shinchris
Copy link
Contributor

Thanks for making the fix @wolkiewiczk.

This project is still active and we are trying to come up with a plan to get more resources to better address issues and pull requests. This change is merged into the development branch, and will make it to master with the v0.10 release, which we plan on doing within the next couple weeks.

@wolkiewiczk
Copy link
Contributor Author

@shinchris Thanks for your response!
It is nice to hear that the project is still developing. Hope to see a new release soon

I wish you the best.

8000

shinchris pushed a commit that referenced this pull request Feb 21, 2020
* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
shinchris pushed a commit that referenced this pull request Feb 21, 2020
Merging v0.10 changes from development to master

* Added a way to handle non-xml errors (#515)
* Added Webhooks endpoints for create, delete, get, list, and test (#523, #532)
* Added delete method in the tasks endpoint (#524)
* Added description attribute to WorkbookItem (#533)
* Added support for materializeViews as schedule and task types (#542)
* Added warnings to schedules (#550, #551)
* Added ability to update parent_id attribute of projects (#560, #567)
* Improved filename behavior for download endpoints (#517)
* Improved logging (#508)
* Fixed runtime error in permissions endpoint (#513)
* Fixed move_workbook_sites sample (#503)
* Fixed project permissions endpoints (#527)
* Fixed login.py sample to accept site name (#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0