Quick Fix for NonXMLErrorException #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graysonarts
reviewed
Oct 24, 2019
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
* Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
shinchris
pushed a commit
that referenced
this pull request
Feb 21, 2020
Merging v0.10 changes from development to master * Added a way to handle non-xml errors (#515) * Added Webhooks endpoints for create, delete, get, list, and test (#523, #532) * Added delete method in the tasks endpoint (#524) * Added description attribute to WorkbookItem (#533) * Added support for materializeViews as schedule and task types (#542) * Added warnings to schedules (#550, #551) * Added ability to update parent_id attribute of projects (#560, #567) * Improved filename behavior for download endpoints (#517) * Improved logging (#508) * Fixed runtime error in permissions endpoint (#513) * Fixed move_workbook_sites sample (#503) * Fixed project permissions endpoints (#527) * Fixed login.py sample to accept site name (#549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix in response to #514.
This should pass through any response body, regardless of whether or not it has one of our well-formed error XML objects in it.
However, it doesn't address all of the reporting user's issues -- for that I think we would need to re-evaluate how we catch exceptions and bubble them up.
The user requested we go back to v0.8.1 functionality, but I believe that would just throw ParseError because of the check in https://github.com/tableau/server-client-python/blob/master/tableauserverclient/server/endpoint/exceptions.py#L17
So let's take this fix now, and we can take some more time to better handle the report from #514