8000 Adding created_at, updated_at and sheet_type properties to view items by opus-42 · Pull Request #331 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

Adding created_at, updated_at and sheet_type properties to view items #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2019
Merged

Adding created_at, updated_at and sheet_type properties to view items #331

merged 5 commits into from
Jul 25, 2019

Conversation

opus-42
Copy link
Contributor
@opus-42 opus-42 commented Aug 25, 2018

Hello,

I noticed that some property fields which are available in the rest API for View Items where not implemented. Here is an implementation for the following fields as describe in the XML schema (https://onlinehelp.tableau.com/samples/en-us/rest_api/ts-api_3_0.xsd) : created_at, updated_at, sheet_type.

The following modification have been applied :

  • Add field property and parsing to ViewItem class
  • Add fields to test assets
  • Add relevant test
  • Update documentation.

I noticed that while describe in the API doc, the sheet_type does not appear in the response on API version 3.0 (tested on Tableau Online).

@t8y8
Copy link
Collaborator
t8y8 commented Sep 10, 2018

Hello!

Thank you for your contribution!

The code looks good but I have a few asks of you:

@opus-42 opus-42 changed the base branch from master to development September 23, 2018 15:39
@opus-42
Copy link
Contributor Author
opus-42 commented Sep 23, 2018

Hello @t8y8,

To answer your questions :

  • Yes I did sign the CLA.
  • I've just changed the base branch of this PR to the develpment branch.

t8y8
t8y8 approved these changes Mar 14, 2019
View reviewed changes
Copy link
Collaborator
@t8y8 t8y8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can confirm the receipt of the CLA, this looks good to me!

(I believe @RussTheAerialist and @benlower have access to check)

@opus-42
Copy link
Contributor Author
opus-42 commented Apr 15, 2019

Hello, any update on this Pull Request ?

Thanks

@jacalata jacalata merged commit 4a279ad into tableau:development Jul 25, 2019
@shinchris shinchris mentioned this pull request Oct 4, 2019
Merged
shinchris pushed a commit that referenced this pull request Oct 4, 2019
Merge pull request #507 from tableau/development
b260ebc 
Release v0.9
## 0.9 (4 Oct 2019)

* Added Metadata API endpoints (#431)
* Added site settings for Data Catalog and Prep Conductor (#434)
* Added new fields to ViewItem (#331)
* Added support and samples for Tableau Server Personal Access Tokens (#465)
* Added Permissions endpoints (#429)
* Added tags to ViewItem (#470)
* Added Databases and Tables endpoints (#445)
* Added Flow endpoints (#494)
* Added ability to filter projects by topLevelProject attribute (#497)
* Improved server_info endpoint error handling (#439)
* Improved Pager to take in keyword arguments (#451)
* Fixed UUID serialization error while publishing workbook (#449)
* Fixed materalized views in request body for update_workbook (#461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@opus-42 @t8y8 @jacalata
0