Add commits to 0.23.X #17084
Merged
Add commits to 0.23.X #17084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* API male load_* args in datasets kwarg only * more loaders * pep8 * fix test_omp usage * fix some usages * Update sklearn/datasets/_samples_generator.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
…scikit-learn#16993) * API pairwise_distances will require explicit V/VI param if Y is given Deprecation until version 0.25. The current approach in `_precompute_metric_params` (https://github.com/scikit-learn/scikit-learn/blob/f82a2cb33871a67b36150647ece1c7e56d3132bb/sklearn/metrics/pairwise.py#L1429-L1444) means that we may be applying a different metric at training and test time. Ideally we'd have a framework for fitting a metric on some specific training data, but in the meantime, this deprecation stops users making mistakes. * DOC update what's new * Update sklearn/metrics/tests/test_pairwise.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update sklearn/metrics/pairwise.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update sklearn/metrics/pairwise.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update sklearn/metrics/tests/test_pairwise.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
…earn#16981) * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
and parametrize_with_checks
…t-learn#16222) * Versionlabels added to v0.18 (#wimlds) * documentation issues: label changed and added for version 0.18 * fix intends and shorten description Co-authored-by: Hannah <32333241+hhnnhh@users.noreply.github.com> Co-authored-by: Brigitte@home <unger@nue.tu-berlin.de>
…cikit-learn#16513) * first few comments * added new california dataset * removed boston dataset from the file * updating the DOCs * adding a DOC for calculating the error * exchanged the order started writing functions on scoring the imputers * finished writing functions for imputers * finished writing functions and started on DOcs * working on the DOCs for imputers * cleaning up * flake8 * cleaning up * cleaning up * restructuring the document * further text restructuring * text restructuring * flake8 * reformatting * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org> * updated the intro * improve bullet point rendering * spelling * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changed the naming * restructuring text * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changing missing values from 0 to nan * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * REGRESSOR to regressor * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * flake8 * reducting number of samples used from california dataset * CLN Removes the need for MissingIndicator * FIX Unrelated bug but is stopping the CI from passing Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Christian Lorentzen <lorentzen.ch@googlemail.com> Co-Authored-By: Nicolas Hug <contact@nicolas-hug.com>
* TST Checks type for derivative check * TST Skips test for 32bit linux * REV Less diffs
|
The travis failure is unrelated. It's interesting that is it showing up here on a PR. (It is failing because it is building with an alpha version of Cython and will be fixed cython/cython#3558) |
|
Please add #14180. It also needs to be added to the release highlights.
|
|
Merging this to test the package builds, still not tagging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #17010
This PR adds the commits we have till now to the branch, and it should also fix the build issue we have in MacPython/scikit-learn-wheels#56
CC @thomasjpfan @NicolasHug @jnothman
This PR should be "rebase and merge" and not "squash and merge".
It adds all the commits we have so far: