-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
[MRG] Added n_components_ to SparsePCA and MiniBatchSparsePCA #16981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@TomDLT could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work !
@jnothman @adrinjalali could you have a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @Reksbril
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
@thomasjpfan does this have your approval? |
tagging for inclusion #17010 |
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
…earn#16981) * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
…earn#16981) * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA * Add whatsnew entry * Fix documentation * Apply suggestions from code review Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Add suggested changes * Update test_sparse_pca.py Co-authored-by: Mateusz Górski <mateuszg122@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
What does this implement/fix? Explain your changes.
I've added n_components_ parameter to SparsePCA and MiniBatchSparsePCA classes to match the behavior of PCA class. See #16752