8000 [MRG] Added n_components_ to SparsePCA and MiniBatchSparsePCA by Reksbril · Pull Request #16981 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

[MRG] Added n_components_ to SparsePCA and MiniBatchSparsePCA #16981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 27, 2020

Conversation

Reksbril
Copy link
Contributor

What does this implement/fix? Explain your changes.

I've added n_components_ parameter to SparsePCA and MiniBatchSparsePCA classes to match the behavior of PCA class. See #16752

@Reksbril Reksbril changed the title Added n_components_ to SparsePCA and MiniBatchSparsePCA [WIP] Added n_components_ to SparsePCA and MiniBatchSparsePCA Apr 21, 2020
@Reksbril
Copy link
Contributor Author

@TomDLT could you have a look?

Copy link
Member
@TomDLT TomDLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

@Reksbril
Copy link
Contributor Author

@jnothman @adrinjalali could you have a look?

Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @Reksbril

@thomasjpfan thomasjpfan changed the title [WIP] Added n_components_ to SparsePCA and MiniBatchSparsePCA [MRG] Added n_components_ to SparsePCA and MiniBatchSparsePCA Apr 26, 2020
Reksbril and others added 3 commits April 27, 2020 08:49
@jnothman
Copy link
Member

@thomasjpfan does this have your approval?

@thomasjpfan thomasjpfan merged commit 41b18fe into scikit-learn:master Apr 27, 2020
@thomasjpfan
Copy link
Member

tagging for inclusion #17010

adrinjalali pushed a commit that referenced this pull request Apr 30, 2020
* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add whatsnew entry

* Fix documentation

* Apply suggestions from code review

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Add suggested changes

* Update test_sparse_pca.py

Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
…earn#16981)

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add whatsnew entry

* Fix documentation

* Apply suggestions from code review

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Add suggested changes

* Update test_sparse_pca.py

Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
…earn#16981)

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add n_components_ attribute to SparcePCA and MiniBatchSparsePCA

* Add whatsnew entry

* Fix documentation

* Apply suggestions from code review

Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>

* Add suggested changes

* Update test_sparse_pca.py

Co-authored-by: Mateusz Górski <mateuszg122@gmail.com>
Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0