[MRG] API make load_* args in datasets kwarg only #16719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The keyword only syntax seems like it needs defaults values in general def hello(a, b, *, c):
print(a, b, c)
hello(1, 2)
# TypeError
hello(1, 2, c=10)
# Works
def hello2(a, b, *, c=10):
print(a, b, c)
hello2(10, 2)
# Works |
jnothman
reviewed
Mar 28, 2020
|
This PR needs #16850 to get merge so it can work with: def make_sparse_coded_signal(n_samples, n_components, *, n_features,
n_nonzero_coefs, random_state=None):
... |
|
Looks like this one is ready for an update @adrinjalali ? |
|
all green. |
NicolasHug
reviewed
Apr 23, 2020
Comment on lines
+21
to
+23
| y, X, gamma = make_sparse_coded_signal(n_samples=n_targets, | ||
| n_components=n_features, | ||
| n_features=n_samples, |
There was a problem hiding this comment.
This one is a bit weird, was the test correct in the first place? Should we change the variables names?
There was a problem hiding this comment.
I'm not sure if it was correct, my gut feeling is that no. But this still passes the test.
There was a problem hiding this comment.
If it passes when re-ordering the args then we should rather do that
I can take over if you're busy with other release stuff, LMK
There was a problem hiding this comment.
I'd be happy if you take over :)
There was a problem hiding this comment.
Well, I tried. A few asserts fail in the test even after switching the values. Just gonna approve as is then
NicolasHug
approved these changes
Apr 27, 2020
thomasjpfan
reviewed
Apr 27, 2020
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
thomasjpfan
approved these changes
Apr 27, 2020
|
tagging #17010 |
adrinjalali
added a commit
that referenced
this pull request
Apr 30, 2020
* API male load_* args in datasets kwarg only * more loaders * pep8 * fix test_omp usage * fix some usages * Update sklearn/datasets/_samples_generator.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
* API male load_* args in datasets kwarg only * more loaders * pep8 * fix test_omp usage * fix some usages * Update sklearn/datasets/_samples_generator.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
* API male load_* args in datasets kwarg only * more loaders * pep8 * fix test_omp usage * fix some usages * Update sklearn/datasets/_samples_generator.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> Co-authored-by: Nicolas Hug <contact@nicolas-hug.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of #15005
This PR makes the dataset loader functions kwonly mostly.
I'm not quite certain about a few of them though.
TODO: fix the decorator for functions
ping @thomasjpfan