-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
TST Skips derivative check on 32bit platforms #17073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST Skips derivative check on 32bit platforms #17073
Conversation
CC @NicolasHug |
I wonder why this is even run in 32 bits since the test is marked with @pytest.mark.skipif(Y_DTYPE != np.float64,
reason='Need 64 bits float precision for numerical checks') |
That statement could always be true, even on 32 bit system since If we want to outright skip this test on 32bit linux, we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed I think the decorator was was wrong,
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch @thomasjpfan
tag for inclusion #17010 |
* TST Checks type for derivative check * TST Skips test for 32bit linux * REV Less diffs
* TST Checks type for derivative check * TST Skips test for 32bit linux * REV Less diffs
* TST Checks type for derivative check * TST Skips test for 32bit linux * REV Less diffs
Fixes build failure in scikit-learn-wheels CI when running on 32bit linux.