10000 TST Skips derivative check on 32bit platforms by thomasjpfan · Pull Request #17073 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST Skips derivative check on 32bit platforms #17073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2020
Merged

TST Skips derivative check on 32bit platforms #17073

merged 3 commits into from
Apr 29, 2020

Conversation

thomasjpfan
Copy link
Member

Fixes build failure in scikit-learn-wheels CI when running on 32bit linux.

@thomasjpfan thomasjpfan added this to the 0.23 milestone Apr 28, 2020
@thomasjpfan thomasjpfan changed the title TST Checks type for derivative check TST Adjusts atol based on dtype for derivative check Apr 28, 2020
@thomasjpfan
Copy link
Member Author

CC @NicolasHug

@NicolasHug
Copy link
Member
NicolasHug commented Apr 28, 2020 •
edited
Loading

I wonder why this is even run in 32 bits since the test is marked with

@pytest.mark.skipif(Y_DTYPE != np.float64,
                    reason='Need 64 bits float precision for numerical checks')

@thomasjpfan
Copy link
Member Author

I wonder why this is even run in 32 bits since the test is marked with

That statement could always be true, even on 32 bit system since sklearn/ensemble/_hist_gradient_boosting/common.pyx explicitly sets it? (This is a guess)

If we want to outright skip this test on 32bit linux, we can use skip_if_32bit.

@thomasjpfan thomasjpfan changed the title TST Adjusts atol based on dtype for derivative check TST Skips derivative check on 32bit platforms Apr 28, 2020
NicolasHug
NicolasHug approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member
@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed I think the decorator was was wrong,
thanks!

@thomasjpfan thomasjpfan mentioned this pull request Apr 29, 2020
Merged
adrinjalali
adrinjalali approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member
@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch @thomasjpfan

@adrinjalali adrinjalali merged commit ad6a9f9 into scikit-learn:master Apr 29, 2020
@adrinjalali
Copy link
Member

tag for inclusion #17010

adrinjalali pushed a commit that referenced this pull request Apr 30, 2020
@thomasjpfan @adrinjalali
TST Skips derivative check on 32bit platforms (#17073)
0fb1ff5 
* TST Checks type for derivative check

* TST Skips test for 32bit linux

* REV Less diffs
gio8tisu pushed a commit to gio8tisu/scikit-learn that referenced this pull request May 15, 2020
@thomasjpfan @gio8tisu
TST Skips derivative check on 32bit platforms (scikit-learn#17073)
bdebebd 
* TST Checks type for derivative check

* TST Skips test for 32bit linux

* REV Less diffs
viclafargue pushed a commit to viclafargue/scikit-learn that referenced this pull request Jun 26, 2020
@thomasjpfan @viclafargue
TST Skips derivative check on 32bit platforms (scikit-learn#17073)
5903218 
* TST Checks type for derivative check

* TST Skips test for 32bit linux

* REV Less diffs
@ogrisel ogrisel mentioned this pull request Jul 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
module:ensemble
Projects
None yet
Milestone
0.23
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasjpfan @NicolasHug @adrinjalali
0