Exchanging Boston for california dataset in plot missing values #16513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into boston_plot_missing_values
…into boston_plot_missing_values
ogrisel
reviewed
Feb 26, 2020
ogrisel
approved these changes
Feb 26, 2020
There was a problem hiding this comment.
Maybe the first paragraph would mention the list of strategies investigated in this example:
- imputation by the constant 0 value
- imputation by the mean value of each feature combined with a missing-ness indicator auxiliary variable
- k nearest neighbor imputation
- iterative imputation
But otherwise LGTM. Thanks very much.
|
The https://85-171681175-gh.circle-artifacts.com/0/doc/auto_examples/impute/plot_missing_values.html |
Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org>
…into boston_plot_missing_values
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
Co-Authored-By: Lucy Liu <jliu176@gmail.com>
…into boston_plot_missing_values
|
@scikit-learn/core-devs time to merge this one? Thanks! |
thomasjpfan
reviewed
Apr 26, 2020
There was a problem hiding this comment.
In a follow up PR, it would be nice to rename get_scores_for_imputer into get_mse_for_imputer and do the negation in the function. This way, we would not need to run:
mses_diabetes = mses_diabetes * -1
mses_california = mses_california * -1before plotting, which can be a little confusing.
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com>
…into boston_plot_missing_values
…into boston_plot_missing_values
adrinjalali
pushed a commit
that referenced
this pull request
Apr 30, 2020
…16513) * first few comments * added new california dataset * removed boston dataset from the file * updating the DOCs * adding a DOC for calculating the error * exchanged the order started writing functions on scoring the imputers * finished writing functions for imputers * finished writing functions and started on DOcs * working on the DOCs for imputers * cleaning up * flake8 * cleaning up * cleaning up * restructuring the document * further text restructuring * text restructuring * flake8 * reformatting * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org> * updated the intro * improve bullet point rendering * spelling * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changed the naming * restructuring text * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changing missing values from 0 to nan * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * REGRESSOR to regressor * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * flake8 * reducting number of samples used from california dataset * CLN Removes the need for MissingIndicator * FIX Unrelated bug but is stopping the CI from passing Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
gio8tisu
pushed a commit
to gio8tisu/scikit-learn
that referenced
this pull request
May 15, 2020
…cikit-learn#16513) * first few comments * added new california dataset * removed boston dataset from the file * updating the DOCs * adding a DOC for calculating the error * exchanged the order started writing functions on scoring the imputers * finished writing functions for imputers * finished writing functions and started on DOcs * working on the DOCs for imputers * cleaning up * flake8 * cleaning up * cleaning up * restructuring the document * further text restructuring * text restructuring * flake8 * reformatting * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org> * updated the intro * improve bullet point rendering * spelling * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changed the naming * restructuring text * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changing missing values from 0 to nan * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * REGRESSOR to regressor * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * flake8 * reducting number of samples used from california dataset * CLN Removes the need for MissingIndicator * FIX Unrelated bug but is stopping the CI from passing Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
viclafargue
pushed a commit
to viclafargue/scikit-learn
that referenced
this pull request
Jun 26, 2020
…cikit-learn#16513) * first few comments * added new california dataset * removed boston dataset from the file * updating the DOCs * adding a DOC for calculating the error * exchanged the order started writing functions on scoring the imputers * finished writing functions for imputers * finished writing functions and started on DOcs * working on the DOCs for imputers * cleaning up * flake8 * cleaning up * cleaning up * restructuring the document * further text restructuring * text restructuring * flake8 * reformatting * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Olivier Grisel <olivier.grisel@ensta.org> * updated the intro * improve bullet point rendering * spelling * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changed the naming * restructuring text * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * changing missing values from 0 to nan * Update examples/impute/plot_missing_values.py Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org> * REGRESSOR to regressor * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Lucy Liu <jliu176@gmail.com> * flake8 * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * Update examples/impute/plot_missing_values.py Co-Authored-By: Thomas J Fan <thomasjpfan@gmail.com> * flake8 * reducting number of samples used from california dataset * CLN Removes the need for MissingIndicator * FIX Unrelated bug but is stopping the CI from passing Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Lucy Liu <jliu176@gmail.com> Co-authored-by: Thomas J Fan <thomasjpfan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
towards #16155
This PR is towards removing Boston dataset from the Sklearn.
It exchanges Boston dataset for California dataset in missing values example
Before:
After:
What does this implement/fix? Explain your changes.
Any other comments?