use a lock when calling unload #9375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2293455)
jsteemann
approved these changes
Jul 2, 2019
ObiWahn
added a commit
that referenced
this pull request
Jul 4, 2019
…ture/one-shard-db * 'devel' of https://github.com/arangodb/arangodb: Pregel additional test & TSan error fix (#9357) use a lock when calling unload (#9375) @maierlars 😍 (#9394) fix typo (#9400) add initializeCursor back to DistinctCollectExecutor (#9386) Feature/add tcpdump support (#9396) apply filters before starting the server, so we can detect whether no test would be executed (#9387) [Devel] Queue-Full-Logging (#9388) add VelocyPackHelper::equal method (#9389) update velocypack version (#9379)
ObiWahn
added a commit
that referenced
this pull request
Jul 4, 2019
…ture/mimalloc * 'devel' of https://github.com/arangodb/arangodb: (37 commits) improve handling when procdump detects the process is dead (#9381) Bug fix/internal issue #586 (#9401) fix tests that didn't properly use env variable to look for test (#9399) Pregel additional test & TSan error fix (#9357) use a lock when calling unload (#9375) @maierlars 😍 (#9394) fix typo (#9400) add initializeCursor back to DistinctCollectExecutor (#9386) Feature/add tcpdump support (#9396) apply filters before starting the server, so we can detect whether no test would be executed (#9387) [Devel] Queue-Full-Logging (#9388) add VelocyPackHelper::equal method (#9389) update velocypack version (#9379) Consistent formatting of CHANGELOG. (#9392) fix JSON statistics (#9385) undo removal (#9391) make sure all error code names are prefixed with ERROR_ @fceller @KVS85 (#9384) remove catch, refresh versions (#9390) fix invalid logId Fix ArangoSearch documentation examples ...
ObiWahn
added a commit
that referenced
this pull request
Jul 4, 2019
…-fix/oasis-statistics * 'devel' of https://github.com/arangodb/arangodb: Don't use non-existent variable (#9407) relax test condition for windows (#9393) improve handling when procdump detects the process is dead (#9381) Bug fix/internal issue #586 (#9401) fix tests that didn't properly use env variable to look for test (#9399) Pregel additional test & TSan error fix (#9357) use a lock when calling unload (#9375) @maierlars 😍 (#9394) fix typo (#9400) add initializeCursor back to DistinctCollectExecutor (#9386) Feature/add tcpdump support (#9396)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Prevent a race when unloading the collection while using it
Related Information
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr-linux/6628/
Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.