relax test condition for windows #9393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joerg84 do you agree with such approach? |
joerg84
reviewed
Jul 4, 2019
| testCreateInParallel: function () { | ||
| let n = 80; | ||
| for (let i = 0; i < n; ++i) { | ||
| let noIndices = 80; |
There was a problem hiding this comment.
Can we add a TODO in the code to fix this and open an internal ticket?
joerg84
approved these changes
Jul 4, 2019
…ax-benchmark-for-windows
|
test blue. |
jsteemann
approved these changes
Jul 4, 2019
| testCreateInParallel: function () { | ||
| let n = 80; | ||
| for (let i = 0; i < n; ++i) { | ||
| let noIndices = 80; |
There was a problem hiding this comment.
Ok, noIndices actually doesn't mean no indexes, but it means number of indexes... So the variable name is at least confusing. When trying to find a prefix for "number" I suggest to use nr, num or just number instead of no in the future. It can stay like this in this PR.
ObiWahn
added a commit
that referenced
this pull request
Jul 4, 2019
…-fix/oasis-statistics * 'devel' of https://github.com/arangodb/arangodb: Don't use non-existent variable (#9407) relax test condition for windows (#9393) improve handling when procdump detects the process is dead (#9381) Bug fix/internal issue #586 (#9401) fix tests that didn't properly use env variable to look for test (#9399) Pregel additional test & TSan error fix (#9357) use a lock when calling unload (#9375) @maierlars 😍 (#9394) fix typo (#9400) add initializeCursor back to DistinctCollectExecutor (#9386) Feature/add tcpdump support (#9396)
ObiWahn
added a commit
that referenced
this pull request
Jul 4, 2019
…ture/one-shard-db * 'devel' of https://github.com/arangodb/arangodb: Don't use non-existent variable (#9407) relax test condition for windows (#9393) improve handling when procdump detects the process is dead (#9381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.