8000 fix JSON statistics for Scheduler by jsteemann · Pull Request #9385 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@jsteemann
Copy link
Contributor

Scope & Purpose

Some statistics were not populated in current devel because of the refactored Scheduler code.
They were reported as "non-representable type" instead. This PR tries to bring back the statistics that were available in 3.4, at least for the metrics that are still available.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behaviour change can only be verified via automatic tests

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5027/

@jsteemann jsteemann added this to the devel milestone Jul 2, 2019
@jsteemann jsteemann requested review from hkernbach and maierlars July 2, 2019 14:42
Copy link
Contributor
@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member
@hkernbach hkernbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann jsteemann merged commit 727bb39 into devel Jul 2, 2019
ObiWahn added a commit that referenced this pull request Jul 3, 2019
…ture/one-shard-db

* 'devel' of https://github.com/arangodb/arangodb:
  Consistent formatting of CHANGELOG. (#9392)
  fix JSON statistics (#9385)
  undo removal (#9391)
  make sure all error code names are prefixed with ERROR_ @fceller @KVS85 (#9384)
  remove catch, refresh versions (#9390)
  fix invalid logId
  Fix ArangoSearch documentation examples
ObiWahn added a commit that referenced this pull request Jul 4, 2019
…ture/mimalloc

* 'devel' of https://github.com/arangodb/arangodb: (37 commits)
  improve handling when procdump detects the process is dead (#9381)
  Bug fix/internal issue #586 (#9401)
  fix tests that didn't properly use env variable to look for test (#9399)
  Pregel additional test & TSan error fix (#9357)
  use a lock when calling unload (#9375)
  @maierlars 😍 (#9394)
  fix typo (#9400)
  add initializeCursor back to DistinctCollectExecutor (#9386)
  Feature/add tcpdump support (#9396)
  apply filters before starting the server, so we can detect whether no test would be executed (#9387)
  [Devel] Queue-Full-Logging (#9388)
  add VelocyPackHelper::equal method (#9389)
  update velocypack version (#9379)
  Consistent formatting of CHANGELOG. (#9392)
  fix JSON statistics (#9385)
  undo removal (#9391)
  make sure all error code names are prefixed with ERROR_ @fceller @KVS85 (#9384)
  remove catch, refresh versions (#9390)
  fix invalid logId
  Fix ArangoSearch documentation examples
  ...
@fceller fceller deleted the bug-fix/fix-scheduler-json-statistics branch July 30, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0