8000 update velocypack version by jsteemann · Pull Request #9379 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@jsteemann
Copy link
Contributor
@jsteemann jsteemann commented Jul 2, 2019

Scope & Purpose

Update velocypack library from upstream repository arangodb/velocypack

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • The behaviour change can only be verified via automatic tests

Testing & Verification

This change is already covered by existing tests, such as velocypack tests, arangodb tests.

Additionally:

  • There are tests in an external testing repository velocypack
  • I ensured this code runs with ASan / TSan or other static verification tools

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5018/

8000

@jsteemann jsteemann added this to the devel milestone Jul 2, 2019
@jsteemann jsteemann requested review from dothebart and maierlars July 2, 2019 11:04
Copy link
Contributor
@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann
Copy link
Contributor Author

@jsteemann
Copy link
Contributor Author

@jsteemann jsteemann merged commit 2f90f5e into devel Jul 3, 2019
ObiWahn added a commit that referenced this pull request Jul 4, 2019
…ture/one-shard-db

* 'devel' of https://github.com/arangodb/arangodb:
  Pregel additional test & TSan error fix (#9357)
  use a lock when calling unload (#9375)
  @maierlars 😍 (#9394)
  fix typo (#9400)
  add initializeCursor back to DistinctCollectExecutor (#9386)
  Feature/add tcpdump support (#9396)
  apply filters before starting the server, so we can detect whether no test would be executed (#9387)
  [Devel] Queue-Full-Logging (#9388)
  add VelocyPackHelper::equal method (#9389)
  update velocypack version (#9379)
BEFE
ObiWahn added a commit that referenced this pull request Jul 4, 2019
…ture/mimalloc

* 'devel' of https://github.com/arangodb/arangodb: (37 commits)
  improve handling when procdump detects the process is dead (#9381)
  Bug fix/internal issue #586 (#9401)
  fix tests that didn't properly use env variable to look for test (#9399)
  Pregel additional test & TSan error fix (#9357)
  use a lock when calling unload (#9375)
  @maierlars 😍 (#9394)
  fix typo (#9400)
  add initializeCursor back to DistinctCollectExecutor (#9386)
  Feature/add tcpdump support (#9396)
  apply filters before starting the server, so we can detect whether no test would be executed (#9387)
  [Devel] Queue-Full-Logging (#9388)
  add VelocyPackHelper::equal method (#9389)
  update velocypack version (#9379)
  Consistent formatting of CHANGELOG. (#9392)
  fix JSON statistics (#9385)
  undo removal (#9391)
  make sure all error code names are prefixed with ERROR_ @fceller @KVS85 (#9384)
  remove catch, refresh versions (#9390)
  fix invalid logId
  Fix ArangoSearch documentation examples
  ...
@fceller fceller deleted the feature/velocypack-serializable branch July 30, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0