8000 [Devel] Queue-Full-Logging by maierlars · Pull Request #9388 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

[Devel] Queue-Full-Logging #9388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2019
Merged

[Devel] Queue-Full-Logging #9388

merged 3 commits into from
Jul 3, 2019

Conversation

@maierlars
Copy link
Contributor
@maierlars maierlars commented Jul 2, 2019

Scope & Purpose

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
  • Strictly new functionality (i.e. a new feature / new option, no need for porting)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behaviour change can only be verified via automatic tests

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

@maierlars maierlars requested a review from neunhoef July 2, 2019 15:14
@maierlars maierlars self-assigned this Jul 2, 2019
@maierlars
Copy link
Contributor Author
maierlars commented Jul 2, 2019

http://jenkins01.arangodb.biz:8080/job/arangodb-matrix-pr/5031/

jsteemann
jsteemann suggested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor
@jsteemann jsteemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, we use camelCase for variable names.
This PR interestingly adds a mix of camelCase and snake_case names, even within the same function 😢

@jsteemann
Copy link
Contributor
jsteemann commented Jul 2, 2019

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/5035/

@jsteemann jsteemann merged commit c4ff5cc into devel Jul 3, 2019
ObiWahn added a commit that referenced this pull request Jul 4, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
c3ba1df 
…ture/one-shard-db

* 'devel' of https://github.com/arangodb/arangodb:
  Pregel additional test & TSan error fix (#9357)
  use a lock when calling unload (#9375)
  @maierlars 😍 (#9394)
  fix typo (#9400)
  add initializeCursor back to DistinctCollectExecutor (#9386)
  Feature/add tcpdump support (#9396)
  apply filters before starting the server, so we can detect whether no test would be executed (#9387)
  [Devel] Queue-Full-Logging (#9388)
  add VelocyPackHelper::equal method (#9389)
  update velocypack version (#9379)
ObiWahn added a commit that referenced this pull request Jul 4, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
cd3c3fc 
…ture/mimalloc

* 'devel' of https://github.com/arangodb/arangodb: (37 commits)
  improve handling when procdump detects the process is dead (#9381)
  Bug fix/internal issue #586 (#9401)
  fix tests that didn't properly use env variable to look for test (#9399)
  Pregel additional test & TSan error fix (#9357)
  use a lock when calling unload (#9375)
  @maierlars 😍 (#9394)
  fix typo (#9400)
  add initializeCursor back to DistinctCollectExecutor (#9386)
  Feature/add tcpdump support (#9396)
  apply filters before starting the server, so we can detect whether no test would be executed (#9387)
  [Devel] Queue-Full-Logging (#9388)
  add VelocyPackHelper::equal method (#9389)
  update velocypack version (#9379)
  Consistent formatting of CHANGELOG. (#9392)
  fix JSON statistics (#9385)
  undo removal (#9391)
  make sure all error code names are prefixed with ERROR_ @fceller @KVS85 (#9384)
  remove catch, refresh versions (#9390)
  fix invalid logId
  Fix ArangoSearch documentation examples
  ...
@fceller fceller deleted the feature/queue-full-logging branch July 30, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neunhoef neunhoef Awaiting requested review from neunhoef

1 more reviewer

@jsteemann jsteemann jsteemann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@maierlars maierlars

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maierlars @jsteemann
0