8000 validation: AQL functions by ObiWahn · Pull Request #11327 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

validation: AQL functions #11327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Apr 1, 2020
Merged

validation: AQL functions #11327

merged 20 commits into from
Apr 1, 2020

Conversation

ObiWahn
Copy link
Contributor
@ObiWahn ObiWahn commented Mar 24, 2020 •
edited
Loading
  • devel only
  • tests - tests/js/common/shell/shell-validation-rocksdb.js
  • documenation

@ObiWahn ObiWahn self-assigned this Mar 24, 2020
@ObiWahn
Merge remote-tracking branch 'origin/devel' into feature/validation-a…
4739daa 
…ql-functions

* origin/devel: (25 commits)
  Bug fix/fixes 20200318 (#11319)
  updated CHANGELOG
  Feature/out of search in range (#11324)
  fix "fix" for collection figures (#11323)
  updated CHANGELOG
  compilation fixes for clang-10s more strict checking (#11316)
  fix failing query (#11317)
  KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312)
  Feature/aql subquery execution block impl execute implementation expected number of rows (#11274)
  Add DTRACE points to measure request timings. (#11245)
  USE_STRICT_OPENSSL is Off by default
  Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314)
  Traversal Bugfix  (#11310)
  Bug fix/issue 11275 (#11299)
  added simple test (#11301)
  Fix some typos (#10173)
  Documentation/typos 2020-01-24 (#10975)
  Update CHANGELOG
  Some cleanup for new executor test code, which accidentally fixes ASAN failures in ExecutorTestHelper (#11283)
  LZ4 update (#11306)
  ...
jsteemann
jsteemann suggested changes Mar 24, 2020
View reviewed changes
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 24, 2020

I still think it is very stupid to block the way to have more than one validator in the future. This will be the last time I mention that. I'll change validation to SCHEMA remove all arrays and so on. But do not complain when it is hard to migrate from one validation method to the next. Because it will be impossible to assert equality in tests and so on.

@jsteemann
Copy link
Contributor

@ObiWahn : noted. But we have to keep usability in balance with internal flexibility. And in case we don't make any use of that flexibility, it just feels stupid to have an unnecessary complex user-facing API and an unnecessary complex internal API.
So let's just go with schema and commit to that.

@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 24, 2020

@jsteemann GET_SCHEMA feels still wrong because it gives you the whole object with level, message, rule and so on. If we use SCHEMA then we should only return the rule and rename the rule to schema. And therefor set in stone that we will never support regex, aql, jaxn config or any other meaningful formats.

@jsteemann
Copy link
Contributor

@ObiWahn : yes, that is fine. Then please make it return just the schema, if there is any, and null otherwise.

@jsteemann
Copy link
Contributor

@ObiWahn : also happy to set this in stone.

ObiWahn added 2 commits March 27, 2020 11:34
@ObiWahn
Make validation in-flexible.
61fa7a8
@ObiWahn
Merge remote-tracking branch 'origin/devel' into feature/validation-a…
a233b7e 
…ql-functions

* origin/devel:
  Bug fix/schema validation return code (#11341)
  Fix explainer output when restricting collections (#11338)
  remove tabstops
  Improve endpoint handling. (#11236)
  revert HTTP return code change for user API, add tests (#11331)
  remove unused header files (#11320)
  Feature/aql subquery execution block impl execute implementation batch sub queries (#11318)
  Fix isAdminUser. (#11326)
@ObiWahn ObiWahn requested a review from jsteemann March 27, 2020 10:38
jsteemann
jsteemann suggested changes Mar 27, 2020
View reviewed changes
@ObiWahn ObiWahn requested review from jsteemann and ifcologne March 27, 2020 10:50
ObiWahn added 2 commits March 27, 2020 12:04
@ObiWahn
Rename Functions and clang-format-6.0 file manually.
99d9b01 
Not using clang-format-9 the spacing is what our formating rules
specify.
@ObiWahn
add tests
b31a7ef
jsteemann
jsteemann suggested changes Mar 30, 2020
View reviewed changes
ObiWahn added 2 commits March 30, 2020 15:35
@ObiWahn
add more tests
c3223c2
@ObiWahn
Merge remote-tracking branch 'origin/devel' into feature/validation-a…
956cca4 
…ql-functions

* origin/devel:
  Introduce more type-safe identifiers (#11270)
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 30, 2020

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9204/

@ObiWahn ObiWahn requested a review from jsteemann March 30, 2020 13:37
@ObiWahn ObiWahn marked this pull request as ready for review March 30, 2020 13:38
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 30, 2020

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9212/

jsteemann
jsteemann suggested changes Mar 31, 2020
View reviewed changes
1E0A
ObiWahn and others added 2 commits March 31, 2020 10:00
@ObiWahn @jsteemann
Apply suggestions from code review
474ee7b 
Co-Authored-By: Jan <jsteemann@users.noreply.github.com>
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
d62f8ee 
…ture/validation-aql-functions

* 'devel' of https://github.com/arangodb/arangodb:
  Allow easier removal of validation rules. (#11346)
@ObiWahn ObiWahn requested a review from jsteemann March 31, 2020 08:12
jsteemann
jsteemann suggested changes Mar 31, 2020
View reviewed changes
@ObiWahn ObiWahn force-pushed the feature/validation-aql-functions branch from 601625c to 2b6d11a Compare March 31, 2020 08:17
@ObiWahn ObiWahn requested a review from jsteemann March 31, 2020 08:27
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Mar 31, 2020

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9222/

Simran-B
Simran-B reviewed Mar 31, 2020
View reviewed changes
ObiWahn added 2 commits April 1, 2020 09:53
@ObiWahn
Rename Function to SCHEMA_GET
28c9f52
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
f9fab9b 
…ture/validation-aql-functions

* 'devel' of https://github.com/arangodb/arangodb:
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Apr 1, 2020

http://jenkins.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9248/

@jsteemann jsteemann merged commit 85e3459 into devel Apr 1, 2020
@jsteemann jsteemann deleted the feature/validation-aql-functions branch April 1, 2020 10:16
ObiWahn added a commit that referenced this pull request Apr 2, 2020
@ObiWahn
Merge branch 'devel' of github.com:arangodb/arangodb into feature/val…
9802a9c 
…idation-web-ui

* 'devel' of github.com:arangodb/arangodb:
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
ObiWahn added a commit that referenced this pull request Apr 6, 2020
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
2dba460 
…ture/utf-8-validation

* 'devel' of https://github.com/arangodb/arangodb: (21 commits)
  Bug fix/headers cleanup (#11391)
  Feature/internal issue #672 (#11370)
  GraphNodes now copy the graph when cloned (#11345)
  fix lame compile error
  Feature/aql subquery execution block impl execute implementation harvesting (#11349)
  remove obsolete recoveryData
  Feature/dismantle mmfiles (#11354)
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
  Allow easier removal of validation rules. (#11346)
  upgrade RocksDB (#11308)
  Introduce more type-safe identifiers (#11270)
  Bug fix/schema validation return code (#11341)
  Fix explainer output when restricting collections (#11338)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simran-B Simran-B Simran-B left review comments

@jsteemann jsteemann jsteemann approved these changes

@ifcologne ifcologne Awaiting requested review from ifcologne

Assignees

@ObiWahn ObiWahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ObiWahn @jsteemann @ifcologne @Simran-B
0