8000 (mostly) restore pre-3.7 API behavior by jsteemann · Pull Request #11364 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

(mostly) restore pre-3.7 API behavior #11364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2020
Merged

(mostly) restore pre-3.7 API behavior #11364

merged 1 commit into from
Apr 1, 2020

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

The API /_admin/cluster/numberOfServers slightly changed in 3.7 compared to 3.6.
This PR reverts the change and also modifies the behavior in some other ways:

  • allow sending HTTP PUT requests to the API with an empty JSON object {} as the request body. This was allowed in 3.6 as well. Sending such request does nothing, but it is allowed.
  • allow using null values for setting the numberOfDBServers and numberOfCoordinators values. This is required for testing the API so the tests can reset the value each time.
  • the return value of successful HTTP PUT requests in 3.6 was just true. In 3.7, we changed it to respond with {"error":false,"code":200}. This change is kept and will be documented as an API change.

Docs companion PR: arangodb/docs#399

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Testing & Verification

This PR adds tests that were used to verify all changes:

  • Added new integration tests (i.e. in shell_client)

http://172.16.10.101:8080/view/PR/job/arangodb-matrix-pr/9260/

@jsteemann jsteemann added this to the devel milestone Apr 1, 2020
@jsteemann jsteemann requested review from ajanikow and maierlars April 1, 2020 15:37
maierlars
maierlars reviewed Apr 1, 2020
View reviewed changes
tests/js/client/shell/shell-numberof-servers-cluster.js
/// Copyright holder is triAGENS GmbH, Cologne, Germany
///
/// @author Jan Steemann
/// @author Copyright 2012, triAGENS GmbH, Cologne, Germany
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't care about that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't. I think we should do a global replace on all files. AFAIK Frank has a script for this, and I will ask him if he can run it once some of the huge PRs are merged.

ajanikow
ajanikow approved these changes Apr 1, 2020
View reviewed changes
Copy link
@ajanikow ajanikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine for me, backward compatibility should be achieved

@jsteemann
Copy link
Contributor Author

Tests blue

@jsteemann jsteemann merged commit a17ef48 into devel Apr 1, 2020
@jsteemann jsteemann deleted the bug-fix/revert-behavior-change-in-admin-cluster-number-of-servers branch April 1, 2020 16:40
jsteemann added a commit that referenced this pull request Apr 1, 2020
@jsteemann
(mostly) restore pre-3.7 API behavior (#11364)
dd2e4b9
ObiWahn added a commit that referenced this pull request Apr 2, 2020
@ObiWahn
Merge branch 'devel' of github.com:arangodb/arangodb into feature/val…
8000
9802a9c 
…idation-web-ui

* 'devel' of github.com:arangodb/arangodb:
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
KVS85 pushed a commit that referenced this pull request Apr 4, 2020
@jsteemann
(mostly) restore pre-3.7 API behavior (#11364) (#11369)
7b16005
ObiWahn added a commit that referenced this pull request Apr 6, 2020
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
2dba460 
…ture/utf-8-validation

* 'devel' of https://github.com/arangodb/arangodb: (21 commits)
  Bug fix/headers cleanup (#11391)
  Feature/internal issue #672 (#11370)
  GraphNodes now copy the graph when cloned (#11345)
  fix lame compile error
  Feature/aql subquery execution block impl execute implementation harvesting (#11349)
  remove obsolete recoveryData
  Feature/dismantle mmfiles (#11354)
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
  Allow easier removal of validation rules. (#11346)
  upgrade RocksDB (#11308)
  Introduce more type-safe identifiers (#11270)
  Bug fix/schema validation return code (#11341)
  Fix explainer output when restricting collections (#11338)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maierlars maierlars maierlars approved these changes

@ajanikow ajanikow ajanikow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
3 participants
@jsteemann @ajanikow @maierlars
0