8000 Fix an agency supervision bug. by neunhoef · Pull Request #11356 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

Fix an agency supervision bug. #11356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Fix an agency supervision bug. #11356

merged 5 commits into from
Apr 2, 2020

Conversation

neunhoef
Copy link
Member

This could temporarily consider a FAILED server as GOOD after an agency
leader change.

@neunhoef
Copy link
Member Author

@neunhoef neunhoef marked this pull request as ready for review March 31, 2020 14:54
@neunhoef neunhoef requested review from kvahed and maierlars March 31, 2020 14:54
syncTime = _transient.hasAsString(syncPrefix + serverID + "/time").first;
syncStatus = _transient.hasAsString(syncPrefix + serverID + "/status").first;
} else {
syncTime = timepointToString(std::chrono::system_clock::time_point()); // beginning of time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the universe is ~50 years old

@neunhoef
Copy link
Member Author
neunhoef commented Apr 1, 2020

Copy link
Contributor
@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neunhoef
8000 Copy link
Member Author
neunhoef commented Apr 1, 2020

New run because jenkins was feeling unwell:
http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9259/

@neunhoef
Copy link
Member Author
neunhoef commented Apr 2, 2020

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/9274/
new run, because Jenkins failed randomly.

@neunhoef neunhoef merged commit 485e14a into devel Apr 2, 2020
@neunhoef neunhoef deleted the bug-fix/new-leader-fake-good branch April 2, 2020 08:18
ObiWahn added a commit that referenced this pull request Apr 2, 2020
…idation-web-ui

* 'devel' of github.com:arangodb/arangodb:
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
ObiWahn added a commit that referenced this pull request Apr 6, 2020
…ture/utf-8-validation

* 'devel' of https://github.com/arangodb/arangodb: (21 commits)
  Bug fix/headers cleanup (#11391)
  Feature/internal issue #672 (#11370)
  GraphNodes now copy the graph when cloned (#11345)
  fix lame compile error
  Feature/aql subquery execution block impl execute implementation harvesting (#11349)
  remove obsolete recoveryData
  Feature/dismantle mmfiles (#11354)
  Fix an agency supervision bug. (#11356)
  (mostly) restore pre-3.7 API behavior (#11364)
  validation: AQL functions (#11327)
  Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351)
  added sleep time (lousy fix)
  Feature/aql interleave function (#11352)
  cheapify IN lookups on unsorted arrays (#11342)
  Bug fix/fix msvc2019 build (#11052)
  Allow easier removal of validation rules. (#11346)
  upgrade RocksDB (#11308)
  Introduce more type-safe identifiers (#11270)
  Bug fix/schema validation return code (#11341)
  Fix explainer output when restricting collections (#11338)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0