Feature/internal issue #672 #11370
Merged
Feature/internal issue #672 #11370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnusi
suggested changes
Apr 2, 2020
| @@ -593,7 +597,7 @@ bool IResearchViewMeta::init(arangodb::velocypack::Slice const& slice, std::stri | |||
| std::string errorSubField; | |||
|
|
|||
| auto const field = slice.get(fieldName); | |||
| mask->_storedValues = field.isArray(); | |||
| mask->_storedValues = !field.isNone(); | |||
There was a problem hiding this comment.
Because if somebody will supply string or object, this will be silently dropped. And one will not know there is nothing stored. It is more important now, as storedValues are excluded from properties output.
gnusi
approved these changes
Apr 3, 2020
| } | ||
| auto const& mangled_name = type->name(); | ||
| TRI_ASSERT(!mangled_name.empty()); | ||
| auto demandled_start = mangled_name.end() - 1; |
ObiWahn
added a commit
that referenced
this pull request
Apr 6, 2020
…ture/utf-8-validation * 'devel' of https://github.com/arangodb/arangodb: (21 commits) Bug fix/headers cleanup (#11391) Feature/internal issue #672 (#11370) GraphNodes now copy the graph when cloned (#11345) fix lame compile error Feature/aql subquery execution block impl execute implementation harvesting (#11349) remove obsolete recoveryData Feature/dismantle mmfiles (#11354) Fix an agency supervision bug. (#11356) (mostly) restore pre-3.7 API behavior (#11364) validation: AQL functions (#11327) Check MSVC_VERSION instead of CMAKE_GENERATOR (#11351) added sleep time (lousy fix) Feature/aql interleave function (#11352) cheapify IN lookups on unsorted arrays (#11342) Bug fix/fix msvc2019 build (#11052) Allow easier removal of validation rules. (#11346) upgrade RocksDB (#11308) Introduce more type-safe identifiers (#11270) Bug fix/schema validation return code (#11341) Fix explainer output when restricting collections (#11338) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds primarySortCompression property to view definition to control compression of primarySort column. Possible values are "lz4"(backward compatible default) and "none" (store without compression)
Changes definition of storedValues property. Now array could contain objects with fields:
{
field: <<field definiton, string or array of strings>>
compression: <> Possible values are "lz4"(backward compatible default) and "none" (store without compression)
}
Fix for internal issue #690 - definition of storedValues excluded from view properties output.
Fixed JACCARD function to return value 1 for two empty arguments.
Verified by js and gtest