Feature/aql subquery execution block impl execute implementation expected number of rows #11274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExecutionBlockImpl (not complete, only skip path) everything compiles, but is not tested
…nd with variants everywhere.
…pose a DataRange, this might not be the correct one every where
…y and SingleRowFetcher. Both untested and yet incomplete, they will only work for MVP.
…SubqueryOperationsStack
…Rows function + test" This reverts commit 2368252.
…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack
…ough. This state is broken in the sense that a server does not boot with it and catch tests are broken
…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack
…e locally green, however there is at least one query still red (on ShadowRows)
This reverts commit aa275b4.
…/arangodb/ArangoDB into feature/AqlSubqueryOperationsStack
…re/AqlSubqueryExecutionBlockImplExecuteImplementation
…ndle ShadowRows properly
…re/AqlSubqueryExecutionBlockImplExecuteImplementation
…ion' of ssh://github.com/arangodb/ArangoDB into feature/AqlSubqueryExecutionBlockImplExecuteImplementation-expectedNumberOfRows
…re/AqlSubqueryExecutionBlockImplExecuteImplementation-expectedNumberOfRows
… end at the shadowRow with input, but EndExecutor will loop here, so it needs more space for output.
… variant that only works on non-copy
…re/AqlSubqueryExecutionBlockImplExecuteImplementation-expectedNumberOfRows
markuspf
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
LGTM, I suggested two typo fixes.
I assume the method is called expectedNumerOfRowsNew so it doesn't clash with the "old" interface and leads to confusing bugs; we might want to have a clean out there later.
I also assume that for all the other excutors that don't have an expectedNumberOfRowsNew, we cannot (easily) make estimates as to the number of outputs produced?
|
@markuspf yes and yes. |
Thanks a lot! Co-Authored-By: Markus Pfeiffer <markuspf@users.noreply.github.com>
…re/AqlSubqueryExecutionBlockImplExecuteImplementation-expectedNumberOfRows
ObiWahn
added a commit
that referenced
this pull request
Mar 25, 2020
…telisting * origin/devel: (80 commits) Feature/aql subquery execution block impl execute implementation batch sub queries (#11318) Fix isAdminUser. (#11326) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG ...
ObiWahn
added a commit
that referenced
this pull request
Mar 27, 2020
…ql-functions * origin/devel: (25 commits) Bug fix/fixes 20200318 (#11319) updated CHANGELOG Feature/out of search in range (#11324) fix "fix" for collection figures (#11323) updated CHANGELOG compilation fixes for clang-10s more strict checking (#11316) fix failing query (#11317) KShortestPathsExecutor must reset its KShortestPathFinder, including all caches. (#11312) Feature/aql subquery execution block impl execute implementation expected number of rows (#11274) Add DTRACE points to measure request timings. (#11245) USE_STRICT_OPENSSL is Off by default Fix usesRevisionAsDocumentId population and add syncByRevision flag (#11314) Traversal Bugfix (#11310) Bug fix/issue 11275 (#11299) added simple test (#11301) Fix some typos (#10173) Documentation/typos 2020-01-24 (#10975) Update CHANGELOG Some cleanup for new executor test code, which accidentally fixes ASAN failures in ExecutorTestHelper (#11283) LZ4 update (#11306) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal performance optimization in Aql.
Governed by existing tests, no changes from User Perspective.
Jenkins:
http://jenkins.arangodb.biz:8080/job/arangodb-matrix-pr/9050/
( All blue)
Internal Note:
This will reactivate the Expected number of output rows to avoid over allocation of blocks.