[Workflow] Entered event #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | symfony#20774 (partially) |
| License | MIT |
| Doc PR | - |
…configuration (nicolas-grekas) This PR was merged into the 3.2 branch. Discussion ---------- [FrameworkBundle] Forbid env parameters in routing configuration | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20682 | License | MIT | Doc PR | - Commits ------- a931002 [FrameworkBundle] Forbid env parameters in routing configuration
released v3.2.0
This PR was merged into the 3.2 branch. Discussion ---------- Fix hide button in toolbar | Q | A | ------------- | --- | Branch? | "3.2" | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | Commits ------- 22e5668 Fix hide button in toolbar
This PR was squashed before being merged into the 3.2 branch (closes symfony#20708). Discussion ---------- Grouping FrameworkBundle upgrade notes | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | License | MIT Commits ------- b8e7779 Grouping FrameworkBundle upgrade notes
This PR was merged into the 3.2 branch. Discussion ---------- [Form] Remove unused var cloner property | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Not used anymore after symfony#19986 EDIT: add missing `use` too. Commits ------- 0708003 [Form] Remove unused var cloner property
…Collector should use cloneVar (ogizanagi) This PR was merged into the 3.2 branch. Discussion ---------- [WebProfilerBundle][Translator] Fix TranslationDataCollector should use cloneVar | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes? | New feature? | no? | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Was missed in symfony#19614 ? ### Before  ### After  Commits ------- 07cdfd5 [WebProfiler][Translator] Fix TranslationDataCollector should use cloneVar
… files (ogizanagi, javiereguiluz) This PR was merged into the 3.2 branch. Discussion ---------- [Serializer] Add deprecation missing from UPGRADE files | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no, simply mention one in upgrade files | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Commits ------- d681c1a Lines length should be 80 or less characters 597bbdc Lines length should be 80 or less characters 4514c1b [Serializer] Add deprecation missing from UPGRADE files
…ofiler open action (ogizanagi) This PR was merged into the 3.2 branch. Discussion ---------- [WebProfilerBundle] Fix vertical alignment for profiler open action | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no, style enhancement | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A ### Before   ### After   Commits ------- 44a0ef1 [WebProfilerBundle] Fix vertical alignment for profiler open action
…esystem loader (4rthem) This PR was merged into the 3.2 branch. Discussion ---------- [TwigBundle] Inject project root path into twig filesystem loader * [TwigBundle] added project root path to filesystem loader | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20726 | License | MIT | Doc PR | - Commits ------- 1094773 inject project root path into twig filesystem loader
… null header values. (Gabriel Moreira) This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes symfony#20747). Discussion ---------- [HttpKernel] Fixed RequestDataCollector handling of null header values. | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR references this [discussion](symfony/http-kernel@1fee784#commitcomment-20028839). Commits ------- adc4a26 [HttpKernel] Fixed RequestDataCollector handling of null header values.
This PR was merged into the 3.2 branch. Discussion ---------- [Form] Fix FormDataCollector | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20698 | License | MIT | Doc PR | - Alternative to symfony#20707 Commits ------- 50400c4 [Form] Add failing test for data collector bug 164a20c [Form] Fix FormDataCollector
…gizanagi) This PR was merged into the 3.2 branch. Discussion ---------- [Serializer] Fix argument object denormalization | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#20670 | License | MIT | Doc PR | N/A Fixes symfony#20670. I've seen symfony#19277 (diff) so I think it's the right thing to do, but I didn't follow the thread at the time, so I may have missed something. Ping @theofidry, @dunglas. Commits ------- 27de65a [Serializer] Fix argument object denormalization
Padam87
pushed a commit
that referenced
this pull request
Feb 9, 2017
…er in autowired classes (brainexe) This PR was squashed before being merged into the 3.1 branch (closes symfony#21372). Discussion ---------- [DependencyInjection] Fixed variadic method parameter in autowired classes | Q | A | ------------- | --- | Branch? | 3.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT Autowiring classes containing methods with variadic method parameter throws a ReflectionException in compile process: ``` PHP Fatal error: Uncaught ReflectionException: Internal error: Failed to retrieve the default value in /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php:437 Stack trace: #0 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(437): ReflectionParameter->getDefaultValue() #1 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(80): Symfony\Component\DependencyInjection\Compiler\AutowirePass::getResourceMetadataForMethod(Object(ReflectionMethod)) #2 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(105): Symfony\Component\DependencyInjection\Compiler\AutowirePass::createResourceForClass(Object(ReflectionClass)) symfony#3 /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php(48): Symfony\Component\DependencyInjection\Compiler\AutowirePass->completeDefinition('__controller.Sw...', Object(Symfony\Component\DependencyInjection\Definition), Array) symfony#4 /.../vendor/symfony/dependency-injection/Compiler/Compiler in /.../vendor/symfony/dependency-injection/Compiler/AutowirePass.php on line 437 ``` **Example:** ``` <?php class FooVariadic { public function bar(...$arguments) { } } $method = new ReflectionMethod(FooVariadic::class, 'bar'); $parameter = $method->getParameters()[0]; $parameter->getDefaultValue(); // -> ReflectionException: Internal error: Failed to retrieve the default value in ... ``` Commits ------- a7f63de [DependencyInjection] Fixed variadic method parameter in autowired classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.