8000 [Workflow] Entered event by Padam87 · Pull Request #2 · Padam87/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Workflow] Entered event #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
a931002
[FrameworkBundle] Forbid env parameters in routing configuration
nicolas-grekas Nov 29, 2016
4514c1b
[Serializer] Add deprecation missing from UPGRADE files
ogizanagi Nov 29, 2016
c500a3e
bug #20687 [FrameworkBundle] Forbid env parameters in routing configu…
fabpot Nov 30, 2016
597bbdc
Lines length should be 80 or less characters
javiereguiluz Nov 30, 2016
d681c1a
Lines length should be 80 or less characters
javiereguiluz Nov 30, 2016
7bfe723
updated CHANGELOG for 3.2.0
fabpot Nov 30, 2016
df8b30b
updated VERSION for 3.2.0
fabpot Nov 30, 2016
b96a144
Merge pull request #20693 from fabpot/release-3.2.0
fabpot Nov 30, 2016
b5520e9
bumped Symfony version to 3.2.1
fabpot Nov 30, 2016
07cdfd5
[WebProfiler][Translator] Fix TranslationDataCollector should use clo…
ogizanagi Nov 30, 2016
44a0ef1
[WebProfilerBundle] Fix vertical alignment for profiler open action
ogizanagi Nov 30, 2016
22e5668
Fix hide button in toolbar
Dec 1, 2016
0708003
[Form] Remove unused var cloner property
ogizanagi Nov 30, 2016
5e77aac
bug #20717 Fix hide button in toolbar (nicolasdewez)
stof Dec 2, 2016
b8e7779
Grouping FrameworkBundle upgrade notes
yceruto Nov 30, 2016
9f9a52c
minor #20708 Grouping FrameworkBundle upgrade notes (yceruto)
fabpot Dec 2, 2016
0c1e9ab
minor #20705 [Form] Remove unused var cloner property (ogizanagi)
fabpot Dec 2, 2016
f8b2a18
bug #20700 [WebProfilerBundle][Translator] Fix TranslationDataCollect…
fabpot Dec 2, 2016
2e780b6
minor #20691 [Serializer] Add deprecation missing from UPGRADE files …
fabpot Dec 2, 2016
27de65a
[Serializer] Fix argument object denormalization
ogizanagi Nov 29, 2016
8c22de4
minor #20702 [WebProfilerBundle] Fix vertical a 8000 lignment for profiler …
fabpot Dec 2, 2016
1094773
inject project root path into twig filesystem loader
4rthem Dec 2, 2016
2d42689
bug #20727 [TwigBundle] Inject project root path into twig filesystem…
fabpot Dec 5, 2016
adc4a26
[HttpKernel] Fixed RequestDataCollector handling of null header values.
Dec 4, 2016
456e68b
bug #20747 [HttpKernel] Fixed RequestDataCollector handling of null h…
fabpot Dec 5, 2016
164a20c
[Form] Fix FormDataCollector
nicolas-grekas Dec 5, 2016
50400c4
[Form] Add failing test for data collector bug
Padam87 Dec 5, 2016
63087e5
bug #20762 [Form] Fix FormDataCollector (nicolas-grekas, Padam87)
fabpot Dec 6, 2016
16cea37
bug #20690 [Serializer] Fix argument object denormalization (ogizanagi)
dunglas Dec 6, 2016
54d66c9
[Workflow] Added an entered event
Padam87 Dec 6, 2016
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/Routing/Router.php
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,10 @@ private function resolve($value)
return '%%';
}

if (preg_match('/^env\(\w+\)$/', $match[1])) {
throw new RuntimeException(sprintf('Using "%%%s%%" is not allowed in routing configuration.', $match[1]));
}

$resolved = $container->getParameter($match[1]);

if (is_string($resolved) || is_numeric($resolved)) {
Expand Down
14 changes: 14 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/Tests/Routing/RouterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,20 @@ public function testPatternPlaceholders()
);
}

/**
* @expectedException \Symfony\Component\DependencyInjection\Exception\RuntimeException
* @expectedExceptionMessage Using "%env(FOO)%" is not allowed in routing configuration.
*/
public function testEnvPlaceholders()
{
$routes = new RouteCollection();

$routes->add('foo', new Route('/%env(FOO)%'));

$router = new Router($this->getServiceContainer($routes), 'foo');
$router->getRouteCollection();
}

public function testHostPlaceholders()
{
$routes = new RouteCollection();
Expand Down
0