[WebProfiler][Translator] Fix TranslationDataCollector should use cloneVar

ogizanagi · ogizanagi · commit 07cdfd533d5f · 2016-11-30T15:40:17.000+01:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/translation.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/translation.html.twig
@@ -183,8 +183,7 @@
 
                         <div id="parameters-{{ loop.index }}" class="hidden">
                             {% for parameters in message.parameters %}
-                                {{ profiler_dump(parameters) }}
-                                {% if not loop.last %}<br />{% endif %}
+                                {{ profiler_dump(parameters, maxDepth=1) }}
                             {% endfor %}
                         </div>
                     {% endif %}
diff --git a/src/Symfony/Component/Translation/DataCollector/TranslationDataCollector.php b/src/Symfony/Component/Translation/DataCollector/TranslationDataCollector.php
@@ -101,12 +101,12 @@ private function sanitizeCollectedMessages($messages)
 
             if (!isset($result[$messageId])) {
                 $message['count'] = 1;
-                $message['parameters'] = !empty($message['parameters']) ? array($message['parameters']) : array();
+                $message['parameters'] = !empty($message['parameters']) ? array($this->cloneVar($message['parameters'])) : array();
                 $messages[$key]['translation'] = $this->sanitizeString($message['translation']);
                 $result[$messageId] = $message;
             } else {
                 if (!empty($message['parameters'])) {
-                    $result[$messageId]['parameters'][] = $message['parameters'];
+                    $result[$messageId]['parameters'][] = $this->cloneVar($message['parameters']);
                 }
 
                 ++$result[$messageId]['count'];
diff --git a/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php b/src/Symfony/Component/Translation/Tests/DataCollector/TranslationDataCollectorTest.php
@@ -13,6 +13,7 @@
 
 use Symfony\Component\Translation\DataCollectorTranslator;
 use Symfony\Component\Translation\DataCollector\TranslationDataCollector;
+use Symfony\Component\VarDumper\Cloner\VarCloner;
 
 class TranslationDataCollectorTest extends \PHPUnit_Framework_TestCase
 {
@@ -39,6 +40,8 @@ public function testCollectEmptyMessages()
 
     public function testCollect()
     {
+        $cloner = new VarCloner();
+
         $collectedMessages = array(
             array(
                   'id' => 'foo',
@@ -115,9 +118,9 @@ public function testCollect()
                   'state' => DataCollectorTranslator::MESSAGE_MISSING,
                   'count' => 3,
                   'parameters' => array(
-                      array('%count%' => 3),
-                      array('%count%' => 3),
-                      array('%count%' => 4, '%foo%' => 'bar'),
+                      $cloner->cloneVar(array('%count%' => 3)),
+                      $cloner->cloneVar(array('%count%' => 3)),
+                      $cloner->cloneVar(array('%count%' => 4, '%foo%' => 'bar')),
                   ),
                   'transChoiceNumber' => 3,
             ),
