8000 [WebProfilerBundle] Fix vertical alignment for profiler open action by ogizanagi · Pull Request #20702 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[WebProfilerBundle] Fix vertical alignment for profiler open action #20702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2016
Merged

[WebProfilerBundle] Fix vertical alignment for profiler open action #20702

merged 1 commit into from
Dec 2, 2016

Conversation

ogizanagi
Copy link
Contributor
Q A
Branch? 3.2
Bug fix? no, style enhancement
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Before

capture d ecran 2016-11-30 a 16 27 14
capture d ecran 2016-11-30 a 16 27 34

After

capture d ecran 2016-11-30 a 16 26 48
capture d ecran 2016-11-30 a 16 27 54

@javiereguiluz
Copy link
Member

👍 the magic of CSS flex! Thanks Maxime.

Status: reviewed

@fabpot
Copy link
Member
fabpot commented Dec 2, 2016

Thank you @ogizanagi.

@fabpot fabpot merged commit 44a0ef1 into symfony:3.2 Dec 2, 2016
fabpot added a commit that referenced this pull request Dec 2, 2016
…open action (ogizanagi)

This PR was merged into the 3.2 branch.

Discussion
----------

[WebProfilerBundle] Fix vertical alignment for profiler open action

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no, style enhancement
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

### Before

![capture d ecran 2016-11-30 a 16 27 14](https://cloud.githubusercontent.com/assets/2211145/20758585/9d9f73ea-b71a-11e6-90d1-75651c22dee6.png)
![capture d ecran 2016-11-30 a 16 27 34](https://cloud.githubusercontent.com/assets/2211145/20758586/9da03596-b71a-11e6-975c-470ef2ca89e5.png)

### After

![capture d ecran 2016-11-30 a 16 26 48](https://cloud.githubusercontent.com/assets/2211145/20758606/a83e4dbc-b71a-11e6-82ea-35b8347ccdef.png)
![capture d ecran 2016-11-30 a 16 27 54](https://cloud.githubusercontent.com/assets/2211145/20758605/a83b2470-b71a-11e6-986c-1ab593a989ea.png)

Commits
-------

44a0ef1 [WebProfilerBundle] Fix vertical alignment for profiler open action
@ogizanagi ogizanagi deleted the fix/profiler_open_alignment branch December 2, 2016 11:52
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
…ofiler open action (ogizanagi)

This PR was merged into the 3.2 branch.

Discussion
----------

[WebProfilerBundle] Fix vertical alignment for profiler open action

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no, style enhancement
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

### Before

![capture d ecran 2016-11-30 a 16 27 14](https://cloud.githubusercontent.com/assets/2211145/20758585/9d9f73ea-b71a-11e6-90d1-75651c22dee6.png)
![capture d ecran 2016-11-30 a 16 27 34](https://cloud.githubusercontent.com/assets/2211145/20758586/9da03596-b71a-11e6-975c-470ef2ca89e5.png)

### After

![capture d ecran 2016-11-30 a 16 26 48](https://cloud.githubusercontent.com/assets/2211145/20758606/a83e4dbc-b71a-11e6-82ea-35b8347ccdef.png)
![capture d ecran 2016-11-30 a 16 27 54](https://cloud.githubusercontent.com/assets/2211145/20758605/a83b2470-b71a-11e6-986c-1ab593a989ea.png)

Commits
-------

44a0ef1 [WebProfilerBundle] Fix vertical alignment for profiler open action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0