8000 [Serializer] Add deprecation missing from UPGRADE files by ogizanagi · Pull Request #20691 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Add deprecation missing from UPGRADE files #20691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2016
Merged

[Serializer] Add deprecation missing from UPGRADE files #20691

merged 3 commits into from
Dec 2, 2016

Conversation

ogizanagi
Copy link
Contributor
Q A
Branch? 3.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no, simply mention one in upgrade files
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@javiereguiluz
Copy link
Member

👍

@ogizanagi
Copy link
Contributor Author

Thanks for the changes @javiereguiluz 😃

@stof
Copy link
Member
stof commented Nov 30, 2016

👍

2 similar comments
@dunglas
Copy link
Member
dunglas commented Nov 30, 2016

👍

@xabbuh
Copy link
Member
xabbuh commented Dec 1, 2016

👍

@fabpot
Copy link
Member
fabpot commented Dec 2, 2016

Thank you @ogizanagi.

@fabpot fabpot merged commit d681c1a into symfony:3.2 Dec 2, 2016
fabpot added a commit that referenced this pull request Dec 2, 2016
@fabpot
minor #20691 [Serializer] Add deprecation missing from UPGRADE files …
2e780b6 
…(ogizanagi, javiereguiluz)

This PR was merged into the 3.2 branch.

Discussion
----------

[Serializer] Add deprecation missing from UPGRADE files

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no, simply mention one in upgrade files
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

d681c1a Lines length should be 80 or less characters
597bbdc Lines length should be 80 or less characters
4514c1b [Serializer] Add deprecation missing from UPGRADE files
@ogizanagi ogizanagi deleted the serializer/3.2/upgrade_file_missing_depr branch December 2, 2016 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ogizanagi @javiereguiluz @stof @dunglas @xabbuh @fabpot @carsonbot
0