[go: up one dir, main page]
Page MenuHomePhabricator
People daniel

daniel (Daniel Kinzler)
User

Projects (18)
View All

Calendar

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2014, 8:08 AM (522 w, 1 d)
Availability
Available
IRC Nick
dues, duesen
LDAP User
Daniel Kinzler
MediaWiki User
DKinzler (WMF) [ Global Accounts ]

Recent Activity
View All

Wed, Oct 2

daniel created P69445 (An Untitled Masterwork).
Wed, Oct 2, 11:14 AM

Mon, Sep 30

daniel created T376063: Hypothesis WE5.2.3 (Q2 FJ24/25): Introduce a system of events and listeners into MediaWiki core.
Mon, Sep 30, 6:00 PM · Epic, MediaWiki-Core-Hooks, MW-Interfaces-Team, OKR-Work, FY2024-25 KR 5.2 Simplify feature development
daniel added a comment to T375899: REST: consider separating "module id" and "module prefix" as separate concepts..

Here we see both forms of module specification. The specs/v0 bit actually specifies the specs/v0 module, per the specs.v0.json module definition file. The content.v1 bit would be our new format for specifying module ids as parameters in urls.

Mon, Sep 30, 5:49 PM · Patch-For-Review, RESTBase-API, MW-Interfaces-Team
daniel added a comment to T375899: REST: consider separating "module id" and "module prefix" as separate concepts..

But that approach is a bit hacky, because it makes assumptions about the module id structure, and it really only works if the module id is the last parameter. Which means that any endpoint that takes two module ids is problematic.

Mon, Sep 30, 5:45 PM · Patch-For-Review, RESTBase-API, MW-Interfaces-Team

Thu, Sep 26

daniel created T375777: REST: add support for re-usable json schema files.
Thu, Sep 26, 3:58 PM · FY2024-25 KR 5.1 MediaWiki Automated API Documentation, OKR-Work, MediaWiki-REST-API, MW-Interfaces-Team

Tue, Sep 24

daniel updated subscribers of T221258: Avoid inserting echo_event rows when not needed.

@Mooeypoo Amir just told me about this task. We should definitly re-think at what point events get inserted into the database.

Tue, Sep 24, 7:07 PM · Growth-Team, MediaWiki-Engineering, Patch-For-Review, Notifications

Tue, Sep 17

daniel added a comment to T374730: Update calls to Maintenance::runChild to instead call Maintenance::createChild.

But it was overriden in CirrusSearch ( https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CirrusSearch/+/1072783 ) which is Wikimedia maintained code and is not the repo that defines it?

Tue, Sep 17, 11:01 AM · MW-1.43-release, MW-1.43-notes (1.43.0-wmf.23; 2024-09-17), Patch-For-Review, MediaWiki-Maintenance-system

Mon, Sep 16

daniel added a comment to T374683: Switchover plan from RESTbase to REST Gateway for rest_v1/page/html and rest_v1/page/title endpoints.

I note that the first of the four listed endpoints ("Get revision metadata for a title") does not yet produce equivalent or compatible output.

Mon, Sep 16, 7:46 PM · RESTBase Sunsetting, serviceops-radar, MW-Interfaces-Team

Thu, Sep 12

daniel moved T373871: Log Api-User-Agent header in Turnilo from Incoming (Needs Triage) to Needs Further Discussion on the MW-Interfaces-Team board.
Thu, Sep 12, 3:27 PM · Analytics-Data-Problem, Traffic, MW-Interfaces-Team
daniel moved T373048: https://en.wikipedia.org/api/ 404 Not Found due to extract2.php RewriteRule from Incoming (Needs Triage) to Radar (other teams work) on the MW-Interfaces-Team board.
Thu, Sep 12, 3:13 PM · MW-on-K8s, Wikimedia-Apache-configuration, Regression, MW-Interfaces-Team
daniel moved T373998: After introduction of /api/ in ATS, https://en.wikipedia.org/api/ returns 404 Not Found from Incoming (Needs Triage) to Radar (other teams work) on the MW-Interfaces-Team board.
Thu, Sep 12, 3:11 PM · Wikimedia-Apache-configuration, Regression, MW-Interfaces-Team
daniel added a comment to T373998: After introduction of /api/ in ATS, https://en.wikipedia.org/api/ returns 404 Not Found.

@akosiaris Did I understand correctly that the rewrite rule for /api/ has been rolld back, so this is solved (for now)?

Thu, Sep 12, 3:11 PM · Wikimedia-Apache-configuration, Regression, MW-Interfaces-Team

Sep 11 2024

daniel moved T336176: Define MediaWiki user types from Inbox, needs triage to MW Platform Team on the MediaWiki-Engineering board.
Sep 11 2024, 1:38 PM · MediaWiki-Platform-Team (Radar), MediaWiki-Engineering, Data-Persistence, Temporary accounts, Data-Engineering, Event-Platform
daniel added a project to T336176: Define MediaWiki user types: MediaWiki-Platform-Team.
Sep 11 2024, 1:38 PM · MediaWiki-Platform-Team (Radar), MediaWiki-Engineering, Data-Persistence, Temporary accounts, Data-Engineering, Event-Platform
daniel edited projects for T341650: Update authentication metrics for IP masking, added: MediaWiki-Platform-Team; removed MediaWiki-Engineering.
Sep 11 2024, 1:35 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), MediaWiki-Platform-Team, Temporary accounts (Blockers to minor pilot wiki deployment), Grafana, MediaWiki-Core-AuthManager
daniel moved T373933: Evaluate publishing our PHP packages directly to Packagist.org from Inbox, needs triage to Needs Input (waiting) on the MediaWiki-Engineering board.
Sep 11 2024, 1:34 PM · SecTeam-Processed, Librarization, Security-Team, MediaWiki-Engineering

Sep 9 2024

daniel merged T374361: Sunset /page/title/ in favor of the new MW bare endpoints into T374136: Route /api/rest_v1/page/title endpoints to MediaWiki core.
Sep 9 2024, 2:44 PM · MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), MW-Interfaces-Team, RESTBase Sunsetting
daniel merged task T374361: Sunset /page/title/ in favor of the new MW bare endpoints into T374136: Route /api/rest_v1/page/title endpoints to MediaWiki core.
Sep 9 2024, 2:42 PM · Parsoid, RESTBase Sunsetting

Sep 5 2024

daniel added a comment to T373874: Send Api-User-Agent header from MediaWiki client-side code.
In T373874#10123148, @Jdlrobson wrote:

@daniel - I assume you are referring to mw.Api client code, but there are other libraries that hit the API too (for example Vector's search uses the native fetch function - https://gerrit.wikimedia.org/g/mediawiki/skins/Vector/+/5f944947e470629172ac17149d456f607c3b87b8/resources/skins.vector.search/fetch.js#32) so applying an API user agent header across the entire MediaWiki product will likely require multiple patches in multiple places.

Sep 5 2024, 8:36 PM · Web-Team-Backlog, Analytics-Data-Problem, MW-Interfaces-Team, Design-System-Team, JavaScript
daniel updated the task description for T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 5:23 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel updated the task description for T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:59 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel added a project to T374135: Migrate RESTbase page content endpoints: Epic.
Sep 5 2024, 4:59 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel updated the task description for T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:58 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel created T374136: Route /api/rest_v1/page/title endpoints to MediaWiki core.
Sep 5 2024, 4:55 PM · MW-1.43-notes (1.43.0-wmf.25; 2024-10-01), MW-Interfaces-Team, RESTBase Sunsetting
daniel added a parent task for T319365: PCS caching and pregeneration when restbase is decommissioned: T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:53 PM · Wikipedia-Android-App-Backlog, Data-Persistence, Patch-For-Review, Epic, User-jijiki, RESTBase Sunsetting, Content-Transform-Team-WIP, Traffic, Wikipedia-iOS-App-Backlog, iOS-app-feature-Performance, RESTBase, serviceops
daniel added a subtask for T374135: Migrate RESTbase page content endpoints: T319365: PCS caching and pregeneration when restbase is decommissioned.
Sep 5 2024, 4:53 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel added a parent task for T334238: Create deprecation plan for public parsoid endpoints: T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:53 PM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel added a parent task for T373716: Reroute RESTbase Parsoid endpoints to core's REST endpoints: T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:52 PM · MediaWiki-REST-API, RESTBase Sunsetting, MW-Interfaces-Team
daniel added subtasks for T374135: Migrate RESTbase page content endpoints: T373716: Reroute RESTbase Parsoid endpoints to core's REST endpoints, T334238: Create deprecation plan for public parsoid endpoints.
Sep 5 2024, 4:52 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel updated the task description for T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:51 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel updated the task description for T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:50 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel created T374135: Migrate RESTbase page content endpoints.
Sep 5 2024, 4:50 PM · Epic, MW-Interfaces-Team, RESTBase Sunsetting
daniel updated the task description for T373716: Reroute RESTbase Parsoid endpoints to core's REST endpoints.
Sep 5 2024, 4:26 PM · MediaWiki-REST-API, RESTBase Sunsetting, MW-Interfaces-Team
daniel updated the task description for T373716: Reroute RESTbase Parsoid endpoints to core's REST endpoints.
Sep 5 2024, 4:23 PM · MediaWiki-REST-API, RESTBase Sunsetting, MW-Interfaces-Team
daniel renamed T373716: Reroute RESTbase Parsoid endpoints to core's REST endpoints from Redirect Parsoid endpoints to REST to Redirect RESTbase Parsoid endpoints to core's REST endpoints.
Sep 5 2024, 4:22 PM · MediaWiki-REST-API, RESTBase Sunsetting, MW-Interfaces-Team

Sep 4 2024

daniel added a comment to T373874: Send Api-User-Agent header from MediaWiki client-side code.
In T373874#10118161, @CCiufo-WMF wrote:

@daniel is this meant to be a discussion prompt or is there a team that should actually own moving this forward? Asking mostly because I don't think this should be a DST/Codex responsibility.

Sep 4 2024, 4:27 PM · Web-Team-Backlog, Analytics-Data-Problem, MW-Interfaces-Team, Design-System-Team, JavaScript

Sep 3 2024

daniel added a comment to T335513: Selective outage of `/wikitext/to/lint` and `/html/to/wikitext` RESTBase endpoints.
In T335513#10109722, @daniel wrote:

It looks like the /html/to/wikitext and /wikitext/to/html endpoints will stay for the foreseeable future.

For the plans for the lint APIs, I really don't know. Maybe @cscott and @MSantos have more information.

Sep 3 2024, 3:18 PM · Parsoid, RESTBase Sunsetting
daniel created T373874: Send Api-User-Agent header from MediaWiki client-side code.
Sep 3 2024, 12:50 PM · Web-Team-Backlog, Analytics-Data-Problem, MW-Interfaces-Team, Design-System-Team, JavaScript
daniel created T373871: Log Api-User-Agent header in Turnilo.
Sep 3 2024, 12:46 PM · Analytics-Data-Problem, Traffic, MW-Interfaces-Team

Sep 2 2024

daniel updated subscribers of T335513: Selective outage of `/wikitext/to/lint` and `/html/to/wikitext` RESTBase endpoints.

It looks like the /html/to/wikitext and /wikitext/to/html endpoints will stay for the foreseeable future.

Sep 2 2024, 10:04 AM · Parsoid, RESTBase Sunsetting

Aug 31 2024

daniel added a comment to T369809: Implement generic MW-API endpoints to replace the math endpoints of restbase.
In T369809#10108051, @Physikerwelt wrote:

When we replaced the database backend with the cache, I investigated that one could use a special type of cache (DB) that stores the data infinitely. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/975432 . Thus, I don't fully understand the problem.

Aug 31 2024, 8:24 AM · RESTBase Sunsetting, Math

Aug 30 2024

daniel added a comment to T370304: Bursts of occasional severe contention on s4 (commonswiki) primary mariadb causing recurrent user-facing outages on all wikis.

In T370304#10073278, @TheDJ wrote:

It used to be that every connection would not return until almost all the work was done, so there used to be a bit of a natural brake on streams like this, but nowadays there is a lot more work that happens after the request completes (for very good reasons btw).

Aug 30 2024, 7:55 AM · User-notice-archive, MediaWiki-Platform-Team (Radar), Vuln-DoS, SecTeam-Processed, Security, Essential-Work, Content-Transform-Team-WIP, Wikimedia-Incident, DBA, Wikimedia-production-error

Aug 29 2024

daniel added a comment to T355376: Replace $wgSharedDb with virtual domains.
In T355376#10082288, @Krinkle wrote:

@daniel Did you get an answer? MWI is part of MWE so I'm unsure whether you meant MWT or MWE. It got moved back to MWI, so I'm guessing something was said or decided?

Aug 29 2024, 8:56 AM · Technical-Debt, MediaWiki-libs-Rdbms, MediaWiki-Core-AuthManager

Aug 28 2024

daniel added a comment to T369809: Implement generic MW-API endpoints to replace the math endpoints of restbase.

Yesterday we discussed the problems that arise when check can't store the rendered formula indefinitely. In that case, any requests that try to retrieve the rendered formula based on the hash will fail.

Aug 28 2024, 7:36 AM · RESTBase Sunsetting, Math

Aug 27 2024

daniel added a comment to T306942: Skins should no longer output HTML and head tag.
In T306942#10061243, @Jdlrobson wrote:

By limiting skins to <body> tag (which we've done already via the deprecation process), we can get more consistency and simplicity in the view layer. Does this make sense?

Aug 27 2024, 10:03 AM · MediaWiki-Engineering, MW-1.43-release, Patch-For-Review, MediaWiki-Core-Skin-Architecture, patch-welcome

Aug 26 2024

daniel updated the task description for T373055: Explore replacing Enotif with an extensible notification system.
Aug 26 2024, 12:35 PM · FY2024-25 KR 5.2 Simplify feature development
daniel added a comment to T368782: MediaWiki Reconciliation API.
In T368782#9939636, @Ottomata wrote:

Hm, a potential problem:

We really don't want this API to be publicly accessible. I'm not certain if we have examples of MW deployed private APIs? Maybe we do and I just don't know it?

Aug 26 2024, 12:01 PM · Data-Engineering (Q2 2024 October 1st - December 31th), Patch-For-Review, Dumps 2.0 (Kanban Board)
daniel added a comment to T368782: MediaWiki Reconciliation API.

Tagging MW-Interfaces-Team for awareness.

Aug 26 2024, 11:59 AM · Data-Engineering (Q2 2024 October 1st - December 31th), Patch-For-Review, Dumps 2.0 (Kanban Board)

Aug 21 2024

daniel created T373055: Explore replacing Enotif with an extensible notification system.
Aug 21 2024, 8:39 PM · FY2024-25 KR 5.2 Simplify feature development
daniel created T373054: Use OpenTelemetry to trace the behavior of hook handlers.
Aug 21 2024, 8:28 PM · Observability-Tracing, FY2024-25 KR 5.2 Simplify feature development
daniel created T373053: Use Huma to analyze hook handler behavior.
Aug 21 2024, 8:24 PM · FY2024-25 KR 5.2 Simplify feature development
daniel added a project to T368677: WE.5.2 (MediaWiki Interventions) Design Research Support: FY2024-25 KR 5.2 Simplify feature development.
Aug 21 2024, 8:18 PM · Research, FY2024-25 KR 5.2 Simplify feature development, Design-Research
daniel added a project to T370267: Hooks and Extension Registry investigation (KR WE5.2.1 FY2024-25): FY2024-25 KR 5.2 Simplify feature development.
Aug 21 2024, 8:15 PM · FY2024-25 KR 5.2 Simplify feature development, OKR-Work, Epic, MediaWiki-Engineering

Aug 20 2024

daniel added a comment to T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes.

Looking at metrics from LinksUpdate, it seems that we could reduce the number of purges a lot, if we wait until after we re-parse to decide whetehr we need to purge or not.

Aug 20 2024, 11:35 AM · Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp

Aug 19 2024

daniel created T372819: Define specs.v1 module.
Aug 19 2024, 6:53 PM · MediaWiki-REST-API, MW-Interfaces-Team
daniel created T372772: REST: include localizable descriptions in generated OpenAPI specs.
Aug 19 2024, 2:18 PM · Patch-For-Review, MediaWiki-REST-API, MW-Interfaces-Team

Aug 12 2024

daniel added a comment to T372164: Special:MentorDashboard broken.
In T372164#10057278, @Urbanecm_WMF wrote:

Hi @daniel, this error was likely caused by the REST refactorings your team is working on IIRC (previously, /w/rest.php/growthexperiments/v0/mentees?order=&sortby=&limit=10&offset=0&prefix=&activedaysago=&maxedits=500&minedits=1&onlystarred=&uselang=en worked, while now it fails with badinteger. The failure is technically correct, as activedaysago is indeed not an integer (but an empty string), but...it used to work before :). Letting you know, in case this is significant to your work. On the Growth's side, we stopped passing params that we don't have a value for, and that remedied the issue.

Aug 12 2024, 1:14 PM · MW-1.43-notes (1.43.0-wmf.17; 2024-08-06), Wikimania-Hackathon-2024, Regression, Growth-Team (FY2024-25 Q1 Sprint 3), GrowthExperiments-Mentorship

Aug 8 2024

daniel added a comment to T371885: Gaps in Grafana graphs using Thanos.
In T371885#10050015, @colewhite wrote:

Possibly $__rate_interval is calculating some interval that yields no data (or not enough data to render a valid rate() result). I tried updating "min step" on the graph to 2m and zooming seems to work with that.

Aug 8 2024, 8:08 AM · SRE Observability (FY2024/2025-Q1), serviceops, MW-on-K8s, Grafana, Observability-Metrics
daniel added a comment to T306942: Skins should no longer output HTML and head tag.

I don't quite understand the reasoning behind this. I think the basic question is: what code should be directly writing to the output buffer (and the WebResponse object)? Should skins build strings, and hand them off to core for output? Or should it be the other way around - core (and extensions) build a data structuer, and the skin generates the response?

Aug 8 2024, 7:56 AM · MediaWiki-Engineering, MW-1.43-release, Patch-For-Review, MediaWiki-Core-Skin-Architecture, patch-welcome

Aug 6 2024

daniel created T371885: Gaps in Grafana graphs using Thanos.
Aug 6 2024, 11:23 AM · SRE Observability (FY2024/2025-Q1), serviceops, MW-on-K8s, Grafana, Observability-Metrics

Aug 5 2024

daniel added a comment to T370430: REST: define the content.v1 module that will replace Parsoid endpoints..
In T370430#10033907, @BPirkle wrote:

Hrm, we have a bit of a chicken-and-egg problem here.

The module itself is defined by a module file in core. It is activated by a corresponding config change, to add the module file to RestAPIAdditionalRouteFiles.

Aug 5 2024, 3:53 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), MW-Interfaces-Team, MediaWiki-REST-API

Jul 18 2024

daniel added a subtask for T334238: Create deprecation plan for public parsoid endpoints: T370430: REST: define the content.v1 module that will replace Parsoid endpoints..
Jul 18 2024, 3:33 PM · Parsoid (Tracking), Content-Transform-Team-WIP, RESTBase Sunsetting
daniel added a parent task for T370430: REST: define the content.v1 module that will replace Parsoid endpoints.: T334238: Create deprecation plan for public parsoid endpoints.
Jul 18 2024, 3:33 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), MW-Interfaces-Team, MediaWiki-REST-API
daniel created T370430: REST: define the content.v1 module that will replace Parsoid endpoints..
Jul 18 2024, 3:33 PM · MW-1.43-notes (1.43.0-wmf.18; 2024-08-13), MW-Interfaces-Team, MediaWiki-REST-API
daniel updated the task description for T368132: REST: Make PARAM_ISMULTI require arrays in JSON.
Jul 18 2024, 3:20 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team
daniel updated the task description for T368132: REST: Make PARAM_ISMULTI require arrays in JSON.
Jul 18 2024, 3:07 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team
daniel renamed T368132: REST: Make PARAM_ISMULTI require arrays in JSON from REST: Make PARAM_IS_MULTI requrie arrays in JSON to REST: Make PARAM_ISMULTI requrie arrays in JSON.
Jul 18 2024, 3:06 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team
daniel moved T368461: REST: decide on a name for the module that will replace the Parsoid endpoints. from In Progress to Done on the MW-Interfaces-Team board.
Jul 18 2024, 2:59 PM · Content-Transform-Team-WIP, RESTBase-API, MediaWiki-REST-API, MW-Interfaces-Team, MediaWiki-Engineering
daniel closed T368461: REST: decide on a name for the module that will replace the Parsoid endpoints. as Resolved.

Everyone seems to be happy with content.v1, so let's do it!

Jul 18 2024, 2:58 PM · Content-Transform-Team-WIP, RESTBase-API, MediaWiki-REST-API, MW-Interfaces-Team, MediaWiki-Engineering
daniel moved T175146: JobQueue: Unify JobRunner entry points from Needs Further Discussion to Backlog (Triaged and Ready) on the MW-Interfaces-Team board.
Jul 18 2024, 2:56 PM · Patch-For-Review, Security, MW-Interfaces-Team, Platform Team Workboards (Initiatives), WMF-JobQueue, TechCom-RFC (TechCom-RFC-Closed), MediaWiki-Core-JobQueue, MediaWiki-Configuration
daniel created T370422: Improve documentation for writing REST handlers.
Jul 18 2024, 2:52 PM · MediaWiki-REST-API, Documentation, MW-Interfaces-Team
daniel triaged T370267: Hooks and Extension Registry investigation (KR WE5.2.1 FY2024-25) as Medium priority.
Jul 18 2024, 11:29 AM · FY2024-25 KR 5.2 Simplify feature development, OKR-Work, Epic, MediaWiki-Engineering

Jul 17 2024

daniel updated the task description for T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes.
Jul 17 2024, 3:22 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp
daniel moved T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes from Inbox, needs triage to Needs Input (waiting) on the MediaWiki-Engineering board.
Jul 17 2024, 1:47 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp
daniel added a project to T370267: Hooks and Extension Registry investigation (KR WE5.2.1 FY2024-25): Epic.
Jul 17 2024, 1:38 PM · FY2024-25 KR 5.2 Simplify feature development, OKR-Work, Epic, MediaWiki-Engineering
daniel updated subscribers of T370267: Hooks and Extension Registry investigation (KR WE5.2.1 FY2024-25).
Jul 17 2024, 1:38 PM · FY2024-25 KR 5.2 Simplify feature development, OKR-Work, Epic, MediaWiki-Engineering
daniel created T370267: Hooks and Extension Registry investigation (KR WE5.2.1 FY2024-25).
Jul 17 2024, 1:37 PM · FY2024-25 KR 5.2 Simplify feature development, OKR-Work, Epic, MediaWiki-Engineering

Jul 16 2024

daniel added a comment to T362006: Provide a Swagger-UI for exploring the core REST API.

See also https://www.mediawiki.org/wiki/Help:RestSandbox

Jul 16 2024, 7:40 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-REST-API, MW-Interfaces-Team, Documentation, API Platform (RESTBase Deprecation Roadmap), Code-Health
daniel closed T362006: Provide a Swagger-UI for exploring the core REST API, a subtask of T262315: <CORE TECHNOLOGY> API Migration & RESTBase Sunset, as Resolved.
Jul 16 2024, 7:39 PM · RESTBase Sunsetting, API Platform (RESTBase Deprecation Roadmap), Epic, Foundational Technology Requests, Code-Health, Platform Engineering Roadmap, Platform Engineering Roadmap Decision Making
daniel closed T362006: Provide a Swagger-UI for exploring the core REST API, a subtask of T353157: Port CampaignEvents REST API documentation to swagger, as Resolved.
Jul 16 2024, 7:39 PM · Campaign-Tools, CampaignEvents
daniel closed T362006: Provide a Swagger-UI for exploring the core REST API as Resolved.
Jul 16 2024, 7:39 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-REST-API, MW-Interfaces-Team, Documentation, API Platform (RESTBase Deprecation Roadmap), Code-Health

Jul 13 2024

daniel added a comment to T157658: Factor out a backend from EditPage.
In T157658#9978424, @DannyS712 wrote:

Well its good to know that the WMF had the plans - are you (collectively) willing to help with code review of more non-trivial patches if I have the time to write the code?

Jul 13 2024, 9:18 AM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), Patch-For-Review, MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), Platform Team Workboards (External Code Reviews), Platform Engineering Roadmap Decision Making, User-DannyS712, MediaWiki-Page-editing

Jul 12 2024

daniel updated subscribers of T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes.
Jul 12 2024, 12:32 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp
daniel created T369898: Reduce the number of resource_change and resource_purge events emitted due to template changes.
Jul 12 2024, 12:24 PM · Essential-Work, MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), serviceops, Performance Issue, MediaWiki-Engineering, MediaWiki-Core-HTTP-Cache, ChangeProp

Jul 11 2024

kostajh awarded T362006: Provide a Swagger-UI for exploring the core REST API a Love token.
Jul 11 2024, 6:07 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-REST-API, MW-Interfaces-Team, Documentation, API Platform (RESTBase Deprecation Roadmap), Code-Health
daniel moved T362006: Provide a Swagger-UI for exploring the core REST API from In Progress to Done on the MW-Interfaces-Team board.

This is now live for testing on https://test.wikipedia.org/wiki/Special:RestSandbox. Please keep in mind that the swagger specs for the MW REST APIs are still incomplete. This is just a preview.

Jul 11 2024, 6:02 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), MediaWiki-REST-API, MW-Interfaces-Team, Documentation, API Platform (RESTBase Deprecation Roadmap), Code-Health
daniel added a project to T369809: Implement generic MW-API endpoints to replace the math endpoints of restbase: RESTBase Sunsetting.
Jul 11 2024, 4:09 PM · RESTBase Sunsetting, Math
daniel moved T369455: ApiPurge: Precondition failed: The PermissionStatus passed as $status parameter must still be good from Incoming (Needs Triage) to Radar (other teams work) on the MW-Interfaces-Team board.
Jul 11 2024, 3:09 PM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, MW-Interfaces-Team, MediaWiki-User-management, MediaWiki-Action-API, Wikimedia-production-error
daniel added a comment to T369455: ApiPurge: Precondition failed: The PermissionStatus passed as $status parameter must still be good.

The root problem is that the fact that the Authority methods need a good Status object as an input isn't really documented.

Jul 11 2024, 3:03 PM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Patch-For-Review, MW-Interfaces-Team, MediaWiki-User-management, MediaWiki-Action-API, Wikimedia-production-error
daniel renamed T368132: REST: Make PARAM_ISMULTI require arrays in JSON from REST: disallow PARAM_IS_MULTI in JSON to REST: Make PARAM_IS_MULTI requrie arrays in JSON.
Jul 11 2024, 2:51 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team

Jul 10 2024

daniel added a comment to T368132: REST: Make PARAM_ISMULTI require arrays in JSON.

If I understood that correctly, then that seems reasonable and I have no objection.

Jul 10 2024, 4:44 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team
daniel added a comment to T368132: REST: Make PARAM_ISMULTI require arrays in JSON.
In T368132#9966698, @FGoodwin wrote:

Restricting to an array seems less disruptive than disallowing PARAM_ISMULTI entirely. What additional tests are needed?

Jul 10 2024, 1:43 PM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team

Jul 9 2024

daniel added a comment to T363084: Remove usage of MediaWiki's JsonBodyValidator from Wikibase REST API.

Thank you!

Jul 9 2024, 5:11 PM · MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), Wikibase Product Platform Team WPP (Sprint 23), MW-Interfaces-Team
daniel added a comment to T367625: REST API considers `v1/transform/wikitext/to/html` to be a write route.
In T367625#9965593, @ABreault-WMF wrote:

This should return true for routes that may require synchronous database writes.
https://github.com/wikimedia/mediawiki/blob/master/includes/Rest/Handler.php#L1041

Jul 9 2024, 3:49 PM · MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), MediaWiki-REST-API
daniel added a comment to T367625: REST API considers `v1/transform/wikitext/to/html` to be a write route.
In T367625#9962597, @ABreault-WMF wrote:

In any case, needsWriteAccess seems to mean synchronous writes.

Jul 9 2024, 11:20 AM · MW-1.43-notes (1.43.0-wmf.13; 2024-07-09), MediaWiki-REST-API
daniel added a comment to T368132: REST: Make PARAM_ISMULTI require arrays in JSON.

I have been wondering if we shoudl take a different approch to this.
We now have the OPT_ENFORCE_JSON_TYPES option, that forces strict type checks on parameters comng from JSON.
We could use that to require an array when PARAM_ISMULTI is set. That way, we'd keep support for PARAM_ISMULTI for body params, without the awkwardness of automatically pslitting strings contained in a JSON structure. For form data, we'd still support that behavior, as before.

Jul 9 2024, 9:45 AM · MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), MediaWiki-REST-API, MW-Interfaces-Team

Jul 8 2024

daniel changed the status of T368133: REST: add structure test that checks if param schemas are valid, a subtask of T366833: REST: Request Body Validation (tracking), from Open to In Progress.
Jul 8 2024, 3:48 PM · MediaWiki-REST-API, Epic, MW-Interfaces-Team
daniel changed the status of T368133: REST: add structure test that checks if param schemas are valid from Open to In Progress.
Jul 8 2024, 3:48 PM · MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), MediaWiki-REST-API, MW-Interfaces-Team

Jul 6 2024

daniel added a comment to T369156: Confusing error hint when passing unrecognised parameters to oauth2/access_token endpoint.
In T369156#9955110, @Tgr wrote:

Failing due to an extra parameter sounds like T360434: REST: request body validation should fail if unexpected fields are present (cc @daniel). It would probably be better for that to either be a warning (I guess that concept would have to be introduced to the REST API first, but it seems useful well beyond this use case) or to follow the B/C break process.

Jul 6 2024, 8:25 AM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), MediaWiki-Platform-Team, MediaWiki-extensions-OAuth

Jul 5 2024

daniel added a comment to T369156: Confusing error hint when passing unrecognised parameters to oauth2/access_token endpoint.

This patch should cause the name of the extra field to be included in the hint.

Jul 5 2024, 8:54 AM · MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), MediaWiki-Platform-Team, MediaWiki-extensions-OAuth
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits