feat: accept parameters for post endpoint #850
Conversation
[Release] Sync master with v0.15 changes ## 0.15.0 (16 Feb 2021) * Added support for python version 3.9 (tableau#744) * Added support for 'Get View by ID' (tableau#750) * Added docs and test data to MANIFEST.in file (tableau#780) * Added owner_id property to ProjectItem (tableau#784) * Added support for skipping connection check while publishing workbook (tableau#791) * Added support for 'Update Subscription' (tableau#794) * Added support for 'Get Groups for a User' (tableau#799) * Improved debug logging by including put/post request contents (tableau#743) * Improved local and active-directory group creation (tableau#770) * Improved 'Update Group' to match server requests/responses (tableau#772) * Improved SiteItem with new properties and functions (tableau#777) * Improved SubscriptionItem with new properties (tableau#794) * Improved the 'type' property of TaskItem to convert server response to enum (tableau#796) * Improved repository to use Github Actions for running tests/linter (tableau#798) * Fixed data_acceleration field causing error in workbook update payload (tableau#741)
Add issue template
This will allow request parameters like timeout to be set by user. Because the metadata api use post_request endpoint, that endpoint will also support adding request parameters. This feature was already present in the GET endpoint
|
Hi @Udit107710 thanks for the pull request! While we wait for a review we'll also need to ask you to submit a Contributor License Agreement - details are listed here: http://tableau.github.io/contributing.html |
|
Generally speaking, this is probably a good idea! However, curious the use case -- the GraphQL API itself has a server-side timeout of 60 seconds by default, is there a reason you want to set that on the client side to a lower value? |
|
@t8y8 I did not know about the 60 sec timeout. But even then, I think it will be good to have common functionality across the endpoints |
|
Thanks Udit for the CLA; updated tags here to reflect. |
|
@Udit107710 fair enough -- but yeah the metadata api times out 60 seconds by default, and returns an error on the Still, change is reasonable -- can you target it against |
|
@jacalata I think you have incorrectly merged development into my branch |
|
@t8y8 Ran the check by |
|
This PR doesn't have the "auto mergeable" checkmark which makes me somewhat nervous -- I think because it was branched from master, it includes the issue template (which we don't need in dev). Can you rebase on development rather than retarget the PR? That should fix it... I think. Otherwise looks good. |
|
Thanks @t8y8 good catch - @Udit107710 I think if you rebase this PR against the current |
|
@Udit107710 reminder ping on this one - could you please rebase your branch from the current |
|
I fixed the conflict, it was an update in content type. |
Thanks @jacalata |
This will allow request parameters like timeout
to be set by user. Because the metadata api use
post_request endpoint, that endpoint will also
support adding request parameters.
This feature was already present in the GET
endpoint
Related issue: #849