-
Notifications
You must be signed in to change notification settings - Fork 436
[Release] Sync master with v0.15 changes #801
8000 New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show contents of methods such as put, post - for empty responses, don't try to print them (avoid [Truncated File Contents] which might appear like an error)
Fixes data_acceleration field always in workbook update payload
Add Python 3.9 for CI builds
Improve debug logging by including put/post request contents (limited to first 1000 chars)
Add Get View by ID
Server versions before 2020.1 do not accept encoded query param delimiters
Fixes issue #754 by moving file read logic inside generator
* Fixes local and ad group creation * Adds tests for validating group field values
Fetch project owner on get, and throw NotImplementedError if we try to set it, until Server itself supports the action Co-authored-by: Jordan Woods <Jordan.Woods@mkcorp.com>
* Update publish_workbook.py (#694) * Update publish_workbook.py Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online parser.add_argument('--sitename', '-S', default='', help='sitename required') tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename) * Update publish_workbook.py Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error. * Update publish_workbook.py * Merge pull request #745 from tableau/fix_732 Server versions before 2020.1 do not accept encoded query param delimiters * Merge pull request #757 from tableau/fix_754 Fixes issue #754 by moving file read logic inside generator * Updates changelog for v0.14.1 * update the site item to reflect api response * update test model * remove extra test assets * trimming line length * unit test all properties. fix some properties. Remove extra code * make requested changes * make requested changes Co-authored-by: Chris Shin <cshin@tableau.com> Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM> Co-authored-by: Terrence Jones <tjones@arkatechture.com>
* Adds skipConnectionCheck flag to publish workbook * Removes unnecessary lines * Fixes style error
* Add fields and parsing logic * Update subscription create request * Adds update request to subscriptions * Changes subscription change request creation to use tsrequest annotation * Update tests for parsing new fields * Fixes codestyle issues * Removes user and schedule name * Fixes test failure
* Update publish_workbook.py (#694) * Update publish_workbook.py Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online parser.add_argument('--sitename', '-S', default='', help='sitename required') tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename) * Update publish_workbook.py Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error. * Update publish_workbook.py * Merge pull request #745 from tableau/fix_732 Server versions before 2020.1 do not accept encoded query param delimiters * Merge pull request #757 from tableau/fix_754 Fixes issue #754 by moving file read logic inside generator * Updates changelog for v0.14.1 * MANIFEST.in: Add docs and test data Closes #779 Co-authored-by: Chris Shin <cshin@tableau.com> Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM>
* Adds task type mapping to translate server response * Updates tests to match server response for task type * Fixes pycodestyle error
* Add support for getting groups that a user belongs to * Use more descriptive name for pager function
* Removes travis and adds github workflow * Addressing code review feedback
jacalata
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't read the whole change closely, trusting our automated checks and previous individual CRs :)
t8y8
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
shinchris
pushed a commit
that referenced
this pull request
Feb 17, 2021
[Release] Sync master with v0.15 changes * Added support for python version 3.9 (#744) * Added support for 'Get View by ID' (#750) * Added docs and test data to MANIFEST.in file (#780) * Added owner_id property to ProjectItem (#784) * Added support for skipping connection check while publishing workbook (#791) * Added support for 'Update Subscription' (#794) * Added support for 'Get Groups for a User' (#799) * Improved debug logging by including put/post request contents (#743) * Improved local and active-directory group creation (#770) * Improved 'Update Group' to match server requests/responses (#772) * Improved SiteItem with new properties and functions (#777) * Improved SubscriptionItem with new properties (#794) * Improved the 'type' property of TaskItem to convert server response to enum (#796) * Improved repository to use Github Actions for running tests/linter (#798) * Fixed data_acceleration field causing error in workbook update payload (#741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing v0.15.0 release:
0.15.0 (16 Feb 2021)