8000 MANIFEST.in: Add docs and test data by jayvdb · Pull Request #780 · tableau/server-client-python · GitHub
[go: up one dir, main page]
Skip to content

MANIFEST.in: Add docs and test data #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 16, 2021
Merged

MANIFEST.in: Add docs and test data #780

merged 8 commits into from
Feb 16, 2021

Conversation

jayvdb
Copy link
Contributor
@jayvdb jayvdb commented Jan 21, 2021

Closes #779

Chris Shin and others added 8 commits September 2, 2020 14:39
Merge pull request tableau#685 from tableau/development
273af7a 
[v0.13] Merge development into master

Added notes field to JobItem (tableau#571)
Added webpage_url field to WorkbookItem (tableau#661)
Added support for switching between sites (tableau#655)
Added support for querying favorites for a user (tableau#656)
Added support for Python 3.8 (tableau#659)
Added support for Data Alerts (tableau#667)
Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (tableau#672)
Added support for creating and querying Active Directory groups (tableau#674)
Added support for asynchronously updating a group (tableau#674)
Improved handling of invalid dates (tableau#529)
Improved consistency of update_permission endpoints (tableau#668)
Documentation updates (tableau#658, tableau#669, tableau#670, tableau#673, tableau#683)
@maddy-at-leisure
Update publish_workbook.py (tableau#694)
8d51355 
* Update publish_workbook.py

Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

parser.add_argument('--sitename', '-S', default='', help='sitename required')
tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

* Update publish_workbook.py

Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

* Update publish_workbook.py
Merge pull request tableau#725 from tableau/development
bcb881c 
Syncing master with v0.14.0 changes from development.
Merge pull request tableau#745 from tableau/fix_732
138476f 
Server versions before 2020.1 do not accept encoded query param delimiters
Merge pull request tableau#757 from tableau/fix_754
41fd8f2 
Fixes issue tableau#754 by moving file read logic inside generator
Updates changelog for v0.14.1
1fc349c
Merge pull request tableau#759 from tableau/0.14.0-patch
a5b9252 
v0.14.1 patch release
* Fixed filter query issue for server version below 2020.1 (tableau#745)
* Fixed large workbook/datasource publish issue (tableau#757)
@jayvdb
MANIFEST.in: Add docs and test data
14e59e0 
Closes tableau#779
@shinchris
Copy link
Contributor

@jayvdb thanks for submitting this pull request - change looks good!

Before we merge this in, could you change the base branch to 'development' rather than master?
Also, could you read and send a CLA to github@tableau.com if you haven't already?

Thanks!

@jayvdb jayvdb changed the base branch from master to development February 1, 2021 23:42
@jayvdb
Copy link
Contributor Author
jayvdb commented Feb 1, 2021

Switched branch the easy way here on Github. I'll do the CLA and rebase this PR properly. Worth noting that no CLA request occurred on tableau/TabPy#473 . There are automated CLA bots which IMO would be a good idea if the intention is to catch all contributors.

@jayvdb
8000 Copy link
Contributor Author
jayvdb commented Feb 2, 2021

Ugh. https://tableau.github.io/2017.02-TableauIndividualCLA.pdf is not an e-form PDF. How are we supposed to electronically sign it as mentioned on https://tableau.github.io/contributing.html ? Use a PDF editor, potentially injecting some modification into the text that your lawyers need to manually check for ?

@bcantoni
Copy link
Contributor
bcantoni commented Feb 3, 2021

@jayvdb yes we are looking at improving the process with CLAbot in the future but at the moment are still using the PDF + email path.

@bcantoni
Copy link
Contributor

Hi @jayvdb sorry for the inconvenience on our current PDF based solution. (A better way is in the works.) I did just test with Adobe Acrobat Reader (free version) and using the "Sign & Fill" option it does work on this particular PDF.

@jayvdb
Copy link
Contributor Author
jayvdb commented Feb 14, 2021

Sent via DocuSign. Hopefully that does the trick.

@bcantoni
Copy link
Contributor

@jayvdb received the CLA and everything looks good, thanks! @shinchris this is ready now from a CLA perspective.

@shinchris shinchris merged commit f64fcf9 into tableau:development Feb 16, 2021
@shinchris
Copy link
Contributor

Thanks @jayvdb!

@shinchris shinchris mentioned this pull request Feb 17, 2021
Merged
shinchris pushed a commit that referenced this pull request Feb 17, 2021
Merge pull request #801 from tableau/release-0.15
ce37a20 
[Release] Sync master with v0.15 changes
## 0.15.0 (16 Feb 2021)
* Added support for python version 3.9 (#744)
* Added support for 'Get View by ID' (#750)
* Added docs and test data to MANIFEST.in file (#780)
* Added owner_id property to ProjectItem (#784)
* Added support for skipping connection check while publishing workbook (#791)
* Added support for 'Update Subscription' (#794)
* Added support for 'Get Groups for a User' (#799)
* Improved debug logging by including put/post request contents (#743)
* Improved local and active-directory group creation (#770)
* Improved 'Update Group' to match server requests/responses (#772)
* Improved SiteItem with new properties and functions (#777)
* Improved SubscriptionItem with new properties (#794)
* Improved the 'type' property of TaskItem to conve
8000
rt server response to enum (#796)
* Improved repository to use Github Actions for running tests/linter (#798)
* Fixed data_acceleration field causing error in workbook update payload (#741)
shinchris pushed a commit that referenced this pull request Feb 17, 2021
Merge pull request #801 from tableau/release-0.15
2767494 
[Release] Sync master with v0.15 changes
* Added support for python version 3.9 (#744)
* Added support for 'Get View by ID' (#750)
* Added docs and test data to MANIFEST.in file (#780)
* Added owner_id property to ProjectItem (#784)
* Added support for skipping connection check while publishing workbook (#791)
* Added support for 'Update Subscription' (#794)
* Added support for 'Get Groups for a User' (#799)
* Improved debug logging by including put/post request contents (#743)
* Improved local and active-directory group creation (#770)
* Improved 'Update Group' to match server requests/responses (#772)
* Improved SiteItem with new properties and functions (#777)
* Improved SubscriptionItem with new properties (#794)
* Improved the 'type' property of TaskItem to convert server response to enum (#796)
* Improved repository to use Github Actions for running tests/linter (#798)
* Fixed data_acceleration field causing error in workbook update payload (#741)
jorwoods added a commit to jorwoods/server-client-python that referenced this pull request Feb 18, 2021
@jorwoods
Squashed commit of the following:
7efb7a6 
commit 2609e27
Merge: d107c48 3a8ec6c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Feb 17 16:00:42 2021 -0800

    Merge pull request tableau#803 from tableau/release-0.15

    syncing development branch with v0.15 changelog

commit d107c48
Author: Tyler Doyle <doyle.tyler@gmail.com>
Date:   Wed Feb 17 15:38:14 2021 -0800

    Add Mypy to CI runs (tableau#802)

    Add mypy runs to CI, but skip misc errors, so we only see the important stuff. For now these are non blocking.

commit 3a8ec6c
Merge: 004ab31 a5b9252
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 16:51:37 2021 -0800

    Merge branch 'master' into release-0.15

commit 004ab31
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 16:49:19 2021 -0800

    Updates changelog and contributors list for v0.15

commit 6c7a87b
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 15:09:45 2021 -0800

    Removes travis and adds linting/testing into github action (tableau#798)

    * Removes travis and adds github workflow

    * Addressing code review feedback

commit 9179637
Author: Lee Boynton <lee@lboynton.com>
Date:   Tue Feb 16 23:09:22 2021 +0000

    Add support for getting groups that a user belongs to (tableau#799)

    * Add support for getting groups that a user belongs to

    * Use more descriptive name for pager function

commit fe992ee
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 14:33:59 2021 -0800

    [Tasks] Translate task type from server to TSC enum (tableau#796)

    * Adds task type mapping to translate server response

    * Updates tests to match server response for task type

    * Fixes pycodestyle error

commit f64fcf9
Author: John Vandenberg <jayvdb@gmail.com>
Date:   Wed Feb 17 01:21:46 2021 +0800

    MANIFEST.in: Add docs and test data (tableau#780)

    * Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

    * Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

    * Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

    * Updates changelog for v0.14.1

    * MANIFEST.in: Add docs and test data

    Closes tableau#779

    Co-authored-by: Chris Shin <cshin@tableau.com>
    Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM>

commit 88a0188
Author: Chris Shin <cshin@tableau.com>
Date:   Tue Feb 16 09:17:35 2021 -0800

    [Subscriptions] Add new fields and ability to update (tableau#794)

    * Add fields and parsing logic

    * Update subscription create request

    * Adds update request to subscriptions

    * Changes subscription change request creation to use tsrequest annotation

    * Update tests for parsing new fields

    * Fixes codestyle issues

    * Removes user and schedule name

    * Fixes test failure

commit 026bca8
Author: Chris Shin <cshin@tableau.com>
Date:   Thu Feb 11 15:34:08 2021 -0800

    Adds skipConnectionCheck to publish workbook (tableau#791)

    * Adds skipConnectionCheck flag to publish workbook

    * Removes unnecessary lines

    * Fixes style error

commit 857199b
Author: tjones-commits <70481977+tjones-commits@users.noreply.github.com>
Date:   Fri Feb 5 17:09:32 2021 -0500

    Update site properties and functions (tableau#777)

    * Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

    * Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

    * Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

    * Updates changelog for v0.14.1

    * update the site item to reflect api response

    * update test model

    * remove extra test assets

    * trimming line length

    * unit test all properties. fix some properties. Remove extra code

    * make requested changes

    * make requested changes

    Co-authored-by: Chris Shin <cshin@tableau.com>
    Co-authored-by: Madhura Selvarajan <MADHURA0910@GMAIL.COM>
    Co-authored-by: Terrence Jones <tjones@arkatechture.com>

commit a5b9252
Merge: bcb881c 1fc349c
Author: Chris Shin <cshin@tableau.com>
Date:   Thu Dec 10 09:29:42 2020 -0800

    Merge pull request tableau#759 from tableau/0.14.0-patch

    v0.14.1 patch release
    * Fixed filter query issue for server version below 2020.1 (tableau#745)
    * Fixed large workbook/datasource publish issue (tableau#757)

commit 1fc349c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 16:30:03 2020 -0800

    Updates changelog for v0.14.1

commit 41fd8f2
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 15:49:48 2020 -0800

    Merge pull request tableau#757 from tableau/fix_754

    Fixes issue tableau#754 by moving file read logic inside generator

commit 138476f
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Dec 9 15:49:23 2020 -0800

    Merge pull request tableau#745 from tableau/fix_732

    Server versions before 2020.1 do not accept encoded query param delimiters

commit bcb881c
Merge: 8d51355 1e089b4
Author: Chris Shin <cshin@tableau.com>
Date:   Mon Nov 9 09:19:23 2020 -0800

    Merge pull request tableau#725 from tableau/development

    Syncing master with v0.14.0 changes from development.

commit 8d51355
Author: Madhura Selvarajan <MADHURA0910@GMAIL.COM>
Date:   Wed Sep 23 10:45:27 2020 -0400

    Update publish_workbook.py (tableau#694)

    * Update publish_workbook.py

    Added below arguments, without this there is a sign-in error on publishing a test file to Tableau Online

    parser.add_argument('--sitename', '-S', default='', help='sitename required')
    tableau_auth = TSC.TableauAuth(args.username, password,site_id=args.sitename)

    * Update publish_workbook.py

    Edits (as requested) to publish workbooks on Tableau Online which removes the Sign-in Error.

    * Update publish_workbook.py

commit 273af7a
Merge: 43e1b06 168489c
Author: Chris Shin <cshin@tableau.com>
Date:   Wed Sep 2 14:39:13 2020 -0700

    Merge pull request tableau#685 from tableau/development

    [v0.13] Merge development into master

    Added notes field to JobItem (tableau#571)
    Added webpage_url field to WorkbookItem (tableau#661)
    Added support for switching between sites (tableau#655)
    Added support for querying favorites for a user (tableau#656)
    Added support for Python 3.8 (tableau#659)
    Added support for Data Alerts (tableau#667)
    Added support for basic Extract operations - Create, Delete, en/re/decrypt for site (tableau#672)
    Added support for creating and querying Active Directory groups (tableau#674)
    Added support for asynchronously updating a group (tableau#674)
    Improved handling of invalid dates (tableau#529)
    Improved consistency of update_permission endpoints (tableau#668)
    Documentation updates (tableau#658, tableau#669, tableau#670, tableau#673, tableau#683)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8y8 t8y8 t8y8 ap 5932 proved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PyPI sdist doesnt contain _utils
5 participants
@jayvdb @shinchris @bcantoni @t8y8 @maddy-at-leisure
0